Author: mav
Date: Sun Jan 15 12:24:23 2017
New Revision: 312228
URL: https://svnweb.freebsd.org/changeset/base/312228

Log:
  Make `camcontrol cmd ... -i ...` return only valid bytes.
  
  Previously code ignored resid field and returned extra zeroes in case of
  data underflow.  Now it returns only real bytes received from target.
  
  MFC after:    2 weeks

Modified:
  head/sbin/camcontrol/camcontrol.c

Modified: head/sbin/camcontrol/camcontrol.c
==============================================================================
--- head/sbin/camcontrol/camcontrol.c   Sun Jan 15 10:33:52 2017        
(r312227)
+++ head/sbin/camcontrol/camcontrol.c   Sun Jan 15 12:24:23 2017        
(r312228)
@@ -4150,7 +4150,7 @@ scsicmd(struct cam_device *device, int a
        u_int8_t cdb[20];
        u_int8_t atacmd[12];
        struct get_hook hook;
-       int c, data_bytes = 0;
+       int c, data_bytes = 0, valid_bytes;
        int cdb_len = 0;
        int atacmd_len = 0;
        int dmacmd = 0;
@@ -4454,16 +4454,20 @@ scsicmd(struct cam_device *device, int a
                }
        }
 
+       if (cdb_len)
+               valid_bytes = ccb->csio.dxfer_len - ccb->csio.resid;
+       else
+               valid_bytes = ccb->ataio.dxfer_len - ccb->ataio.resid;
        if (((ccb->ccb_h.status & CAM_STATUS_MASK) == CAM_REQ_CMP)
         && (arglist & CAM_ARG_CMD_IN)
-        && (data_bytes > 0)) {
+        && (valid_bytes > 0)) {
                if (fd_data == 0) {
-                       buff_decode_visit(data_ptr, data_bytes, datastr,
+                       buff_decode_visit(data_ptr, valid_bytes, datastr,
                                          arg_put, NULL);
                        fprintf(stdout, "\n");
                } else {
                        ssize_t amt_written;
-                       int amt_to_write = data_bytes;
+                       int amt_to_write = valid_bytes;
                        u_int8_t *buf_ptr = data_ptr;
 
                        for (amt_written = 0; (amt_to_write > 0) &&
@@ -4478,7 +4482,7 @@ scsicmd(struct cam_device *device, int a
                        } else if ((amt_written == 0)
                                && (amt_to_write > 0)) {
                                warnx("only wrote %u bytes out of %u",
-                                     data_bytes - amt_to_write, data_bytes);
+                                     valid_bytes - amt_to_write, valid_bytes);
                        }
                }
        }
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to