With this change merged to 11-CURRENT my SHEEVAPLUG/arm displays different
information in dmesg:
messages:Apr 15 00:53:07 sheeva2 kernel: Little-endian DC enabled IC
enabled WA disabled DC streaming enabled
messages:Apr 15 00:53:07 sheeva2 kernel: WB enabled LABT branch prediction
enabled
messages.0.bz2:Apr 11 20:02:06 sheeva2 kernel: Little-endian DC enabled IC
disabled WA disabled DC streaming enabled
messages.0.bz2:Apr 11 20:02:06 sheeva2 kernel: WB enabled LABT branch
prediction disabled
IC changed from disabled to enabled and LABT branch prediction is
displayed as enabled also.
Is this only cosmetically? Or does it really change behaviour?
Anybody willing to MFC this 11?
Regards,
Ronald.
On Mon, 06 Feb 2017 15:58:24 +0100, Stanislav Galabov
<sgala...@freebsd.org> wrote:
Author: sgalabov
Date: Mon Feb 6 14:58:24 2017
New Revision: 313343
URL: https://svnweb.freebsd.org/changeset/base/313343
Log:
sys/arm/arm/identcpu-v4.c: fix identify_arm_cpu()
identify_arm_cpu() in sys/arm/arm/identcpu-v4.c incorrectly uses a
u_int8_t variable to store the result of cpu_get_control().
It should really use a u_int variable, the same way as done for
cpu_ident()
in the same function, as both cpuid and control registers are 32-bit..
This issue causes users of identcpu-v4 to incorrectly report things
such as
icache status (bit 12 in cpu control register) and basically anything
defined in bits above bit 7 :-)
Reviewed by: manu
Sponsored by: Smartcom - Bulgaria AD
Differential Revision: https://reviews.freebsd.org/D9460
Modified:
head/sys/arm/arm/identcpu-v4.c
Modified: head/sys/arm/arm/identcpu-v4.c
==============================================================================
--- head/sys/arm/arm/identcpu-v4.c Mon Feb 6 14:41:34 2017
(r313342)
+++ head/sys/arm/arm/identcpu-v4.c Mon Feb 6 14:58:24 2017
(r313343)
@@ -294,8 +294,7 @@ u_int cpu_pfr(int num)
void
identify_arm_cpu(void)
{
- u_int cpuid;
- u_int8_t ctrl;
+ u_int cpuid, ctrl;
int i;
ctrl = cpu_get_control();
_______________________________________________
svn-src-...@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
