On Friday, April 14, 2017 02:10:56 PM Maxim Sobolev wrote: > Peter, Ngie, > > Looks like out of that refactoring came a logical bug that is present in > the head, which causes syslod to first to shutdown the socket for reading > and then try to select/recv on it (which is somewhat stupid). And that > issue has been masked by shutdown() on datagram socket becoming effectively > a NOP in 11 & head 20 months ago. It only affects head though, 11-stable > still has the old code which does not include that half-closed socket into > the select list. Attached patch is expected to fix head, Peter, it would be > nice if you can give it a try (restoring latest changes into > uipc_sockets.c) and let me know if it helps.
Confirmed - resting uipc_socket.c to HEAD and applying the patch to syslogd does solve the problem we encountered. Thanks! > Thanks! > > On Fri, Apr 14, 2017 at 12:48 PM, Ngie Cooper (yaneurabeya) < > > yaneurab...@gmail.com> wrote: > > > On Apr 14, 2017, at 12:46, Peter Wemm <pe...@wemm.org> wrote: > > > > > > On Friday, April 14, 2017 12:41:52 PM Maxim Sobolev wrote: > > >> Thanks, Peter. I will try to look into this asap. > > > > > > I don't understand what is going on yet. Presumably there must be other > > > changes in play that affect udp/select sometime between the original > > > 2015 > > > change and this. The syslogd -s code is Old(TM). I'm also wondering > > > > whether > > > > > the -s code even works at all since the 2015 / r285910 change... > > > > syslogd has been refactored a lot on ^/head. I don’t think it’s safe to > > say that the ^/head and ^/stable/11 and earlier copies will function the > > same. > > Thanks, > > -Ngie -- Peter Wemm - pe...@wemm.org; pe...@freebsd.org; pe...@yahoo-inc.com; KI6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246
signature.asc
Description: This is a digitally signed message part.