On 25/01/2018 09:42, Bruce Evans wrote:
On Wed, 24 Jan 2018, Pedro F. Giffuni wrote:
Log:
Revert r327781, r328093, r328056:
ufs|ext2fs: Revert uses of mallocarray(9).
These aren't really useful: drop them.
Variable unsigning will be brought again later.
Variable "unsigning" (that is, adding unsign extension bugs) is even more
negatively useful than mallocarray(), so should not be brought back.
Any specific case? I already brought those back in r328346.
Unsigning variables used _only_ for array sizes and element counts
doesn't
cause any new problems (and fixes warnings about converting from
signed to
unsigned when calling malloc*()), but it is a lot of work to check that
they aren't used for other things where their signedness matters (perhaps
differences or loops that count down to -1 instead of 0).
I did check and had mckusick crosscheck before, but as you say it is
usually a lot of work and my have missed something.
Pedro.
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
