Author: bdrewery
Date: Thu Oct 2 18:12:18 2014
New Revision: 272435
URL: https://svnweb.freebsd.org/changeset/base/272435
Log:
MFC r271720:
If fgets(3) fails in getbounds(), show strerror(3) if not an EOF. Also fix a
FILE* leak in getbounds().
PR: 192032
Modified:
stable/9/sbin/savecore/savecore.c
Directory Properties:
stable/9/sbin/savecore/ (props changed)
Modified: stable/9/sbin/savecore/savecore.c
==============================================================================
--- stable/9/sbin/savecore/savecore.c Thu Oct 2 18:11:13 2014
(r272434)
+++ stable/9/sbin/savecore/savecore.c Thu Oct 2 18:12:18 2014
(r272435)
@@ -149,7 +149,10 @@ getbounds(void) {
}
if (fgets(buf, sizeof buf, fp) == NULL) {
- syslog(LOG_WARNING, "unable to read from bounds, using 0");
+ if (feof(fp))
+ syslog(LOG_WARNING, "bounds file is empty, using 0");
+ else
+ syslog(LOG_WARNING, "bounds file: %s", strerror(errno));
fclose(fp);
return (ret);
}
@@ -158,6 +161,7 @@ getbounds(void) {
ret = (int)strtol(buf, NULL, 10);
if (ret == 0 && (errno == EINVAL || errno == ERANGE))
syslog(LOG_WARNING, "invalid value found in bounds, using 0");
+ fclose(fp);
return (ret);
}
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-stable-9
To unsubscribe, send any mail to "[email protected]"
