debian/changelog | 12 ++++ lib/Vyatta/Config.pm | 117 +++++++++++++++++---------------------------- lib/Vyatta/ConfigOutput.pm | 2 3 files changed, 59 insertions(+), 72 deletions(-)
New commits: commit 76949e545bac7372642bb79cba3c1c3ea8fef871 Author: Stephen Hemminger <[email protected]> Date: Wed Feb 4 11:09:03 2009 -0800 0.14.8 commit 4311b83716b52b47969e4523128c77131c4da87e Author: Stephen Hemminger <[email protected]> Date: Wed Feb 4 11:04:34 2009 -0800 Vyatta::Config - exists simplification No need for if (-d node) { return ... can just use use return ( -d node ) commit fc8d551687df0c874e6262b5ec7ebb574f2b1980 Author: Stephen Hemminger <[email protected]> Date: Wed Feb 4 11:01:02 2009 -0800 Vyatta::ConfigOutput - test for exists should not use defined exists returns a boolean so no need to explicitly check for defined. commit 9f171d3f9c52c9be5fa281d9b7d8ad7c22f66c27 Author: Stephen Hemminger <[email protected]> Date: Wed Feb 4 10:57:58 2009 -0800 Vyatta::Config - don't use global handle for opendir Global file handles are trap waiting to happen. commit d8922b367e5d45dc8bb2b5dfba59d9473c3403e8 Author: Stephen Hemminger <[email protected]> Date: Wed Feb 4 10:55:45 2009 -0800 Vyatta::Config - simplify boolean When returning boolean no need to have if (expr) return 1; else return 0 Also the proper boolean for false is undef not 0. commit eb17b185a339fb73059899f5a0bcbac987745002 Author: Stephen Hemminger <[email protected]> Date: Wed Feb 4 10:51:58 2009 -0800 Vyatta::Config - fix perlcritic warnings from dangling return commit eaf4e68ae42b1e4e5c4f5ca0ea944c0ab383157b Author: Stephen Hemminger <[email protected]> Date: Wed Feb 4 10:15:50 2009 -0800 Vyatta::Config::returnValue - change to three argument open Using three argument open is safer against global handle clash, and accidental scripting. http://suva.vyatta.com/git/?p=vyatta-cfg.git;a=commitdiff;h=76949e545bac7372642bb79cba3c1c3ea8fef871 http://suva.vyatta.com/git/?p=vyatta-cfg.git;a=commitdiff;h=4311b83716b52b47969e4523128c77131c4da87e http://suva.vyatta.com/git/?p=vyatta-cfg.git;a=commitdiff;h=fc8d551687df0c874e6262b5ec7ebb574f2b1980 http://suva.vyatta.com/git/?p=vyatta-cfg.git;a=commitdiff;h=9f171d3f9c52c9be5fa281d9b7d8ad7c22f66c27 http://suva.vyatta.com/git/?p=vyatta-cfg.git;a=commitdiff;h=d8922b367e5d45dc8bb2b5dfba59d9473c3403e8 http://suva.vyatta.com/git/?p=vyatta-cfg.git;a=commitdiff;h=eb17b185a339fb73059899f5a0bcbac987745002 http://suva.vyatta.com/git/?p=vyatta-cfg.git;a=commitdiff;h=eaf4e68ae42b1e4e5c4f5ca0ea944c0ab383157b _______________________________________________ svn mailing list [email protected] http://mailman.vyatta.com/mailman/listinfo/svn
