On Sun, 26 Apr 2009 18:51:55 -0700 Stig Thormodsrud <[email protected]> wrote:
> Makefile.am | 1 > debian/vyatta-cfg-system.postinst.in | 3 > scripts/vyatta-banner.pl | 130 > ++++++++++++++++++++++ > templates/system/login/banner/node.def | 1 > templates/system/login/banner/post-login/node.def | 12 ++ > templates/system/login/banner/pre-login/node.def | 13 ++ > 6 files changed, 160 insertions(+) > > New commits: > commit f8e69a9cd0110168e270a1b95813ce0b4adfe283 > Author: Stig Thormodsrud <[email protected]> > Date: Sun Apr 26 18:51:04 2009 -0700 > > Add configurable login banners. > > http://suva.vyatta.com/git/?p=vyatta-cfg-system.git;a=commitdiff;h=f8e69a9cd0110168e270a1b95813ce0b4adfe283 > _______________________________________________ > svn mailing list > [email protected] > http://mailman.vyatta.com/mailman/listinfo/svn Minor comments: 1. It should not rewrite the file if not necessary. 2. You don't have to use system() as much; the are file operations in perl such as unlink() and rename() that work for many things; or use File::Copy module. _______________________________________________ svn mailing list [email protected] http://mailman.vyatta.com/mailman/listinfo/svn
