net/netfilter/nf_conntrack_netlink.c | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
New commits: commit 7ece97ed679d8b04845225f49473da0a0b119e2d Author: Stephen Hemminger <[email protected]> Date: Sat Nov 27 10:05:44 2010 -0800 netfilter: fix race in conntrack between dump_table and destroy The netlink interface to dump the connection tracking table has a race when entries are deleted at the same time. A customer reported a crash and the backtrace showed thatctnetlink_dump_table was running while a conntrack entry wasbeing destroyed. (see https://bugzilla.vyatta.com/show_bug.cgi?id=6402). According to RCU documentation, when using hlist_nulls the reader must handle the case of seeing a deleted entry and not proceed further down the linked list. The old code would continue which caused the scan to walk into the free list. This patch uses locking (rather than RCU) for this operation which is guaranteed safe, and no longer requires getting reference while doing dump operation. Signed-off-by: Stephen Hemminger <[email protected]> http://suva.vyatta.com/git/?p=linux-vyatta.git;a=commitdiff;h=7ece97ed679d8b04845225f49473da0a0b119e2d _______________________________________________ svn mailing list [email protected] http://mailman.vyatta.com/mailman/listinfo/svn
