On Fri, Sep 15, 2017 at 11:17:43PM -0400, D. Hugh Redelmeier wrote: > | From: Antony Antony <ant...@phenome.org> > > coverity-detected anomalies are sometimes subtle. So I looked at this > code and found a couple of bugs. I also did some tidying. But no > testing! > > Aviv, Antony: please have a look at commit > f7aaa80198851ef71da4be8dc54e816f7064e29a > > Note: % 31 is almost never correct. I think that in this code, + 31 is > also wrong.
Thanks DHR. This commit looks good to me. It address my concerns too. > Could someone with real hardware test this code? not me. I have no acess to the real hardware to test. -antony _______________________________________________ Swan-dev mailing list Swan-dev@lists.libreswan.org https://lists.libreswan.org/mailman/listinfo/swan-dev