IMHO you can go ahead and land the revert, it is trivial. It's unfortunate we don't have a good way to manage this yet -- my suggestion would be that when it is ready to land (again) and well tested just land both patches in mainline. I realize that is unfortunate, but it is more reliable than waiting to land them independently with the @swift-ci lag.
- Daniel > On Aug 17, 2016, at 8:01 PM, Greg Parker <gpar...@apple.com> wrote: > > #4361 failed its Linux smoke test and never started its OS X test. I'm > reverting once I find the right thing to revert. If you want to fix it, work > fast. > > >> On Aug 17, 2016, at 4:57 PM, Daniel Dunbar <daniel_dun...@apple.com >> <mailto:daniel_dun...@apple.com>> wrote: >> >> I suspect it is just waiting on: >> https://github.com/apple/swift/pull/4361 >> <https://github.com/apple/swift/pull/4361> >> to finish testing, which it looks like is close. >> >> - Daniel >> >>> On Aug 17, 2016, at 4:54 PM, Greg Parker via swift-dev <swift-dev@swift.org >>> <mailto:swift-dev@swift.org>> wrote: >>> >>> This is about to break all of the bots. When do you expect a fix? >>> >>>> On Aug 17, 2016, at 4:28 PM, Max Moiseev via swift-dev >>>> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >>>> >>>> Unfortunate but expected. Need this change in the SwiftPM in order to test >>>> the https://github.com/apple/swift/pull/4361 >>>> <https://github.com/apple/swift/pull/4361>. >>>> >>>>> On Aug 17, 2016, at 4:22 PM, no-re...@swift.org >>>>> <mailto:no-re...@swift.org> wrote: >>>>> >>>>> [FAILURE] oss-swift-3.0-incremental-RA-linux-ubuntu-15_10 [#106] >>>>> >>>>> Build URL: >>>>> https://ci.swift.org/job/oss-swift-3.0-incremental-RA-linux-ubuntu-15_10/106/ >>>>> >>>>> <https://ci.swift.org/job/oss-swift-3.0-incremental-RA-linux-ubuntu-15_10/106/> >>>>> Project: oss-swift-3.0-incremental-RA-linux-ubuntu-15_10 >>>>> Date of build: Wed, 17 Aug 2016 16:06:24 -0700 >>>>> Build duration: 16 min >>>>> Identified problems: >>>>> >>>>> Compile Error: This build failed because of a compile error. Below is a >>>>> list of all errors in the build log: >>>>> Indication 1 >>>>> <https://ci.swift.org//job/oss-swift-3.0-incremental-RA-linux-ubuntu-15_10/106/consoleFull#-661780602ee1a197b-acac-4b17-83cf-a53b95139a76> >>>>> Changes >>>>> >>>>> Commit 95e92d5c6cfada9687f9d40822e1c78166e1a752 by jgroff: >>>>> SILGen: Set context generic params for bridging thunks. >>>>> >>>>> add: test/SILGen/Inputs/objc_bridged_generic_conformance.h >>>>> edit: lib/SILGen/SILGenBridging.cpp >>>>> add: test/SILGen/objc_bridged_generic_conformance.swift >>>>> >>>>> Commit 9ae709d135597d8421ba34f7d705aa17491890dd by jgroff: >>>>> IRGen: Correctly register conformances for generic ObjC classes. >>>>> >>>>> edit: lib/IRGen/GenDecl.cpp >>>>> add: test/IRGen/Inputs/objc_bridged_generic_conformance.h >>>>> add: test/IRGen/objc_bridged_generic_conformance.swift >>>>> >>>>> Commit 5f65fa8594735cc579cd883bc252b0ef601c792d by moiseev: >>>>> Removing the TextOutputStreamable typealias... >>>>> >>>>> delete: Sources/Basic/SwiftShims.swift >>>> >>>> _______________________________________________ >>>> swift-dev mailing list >>>> swift-dev@swift.org <mailto:swift-dev@swift.org> >>>> https://lists.swift.org/mailman/listinfo/swift-dev >>>> <https://lists.swift.org/mailman/listinfo/swift-dev> >>> >>> _______________________________________________ >>> swift-dev mailing list >>> swift-dev@swift.org <mailto:swift-dev@swift.org> >>> https://lists.swift.org/mailman/listinfo/swift-dev >>> <https://lists.swift.org/mailman/listinfo/swift-dev> >> >
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev
