> On Mar 19, 2017, at 4:59 PM, Greg Parker <gpar...@apple.com> wrote: > > Michael, one of your changes broke all three ASAN bots. Please fix or revert > ASAP. > > (Could this be related to https://github.com/apple/swift/pull/8169 > <https://github.com/apple/swift/pull/8169> ? I didn't confirm that the bot's > change lists are correct.)
It is more complicated than you would think. I looked at this earlier. The change itself looks benign and in fact it was happening without ASAN when I had written it in a previous manner. I thought it was a compiler bug so I rewrote it in a simpler manner and the problem went away. If you look at 53eab13be8dd1202428af1b5c315f17c1ab02186, I am just moving some code into a method. It is not related to the other PR which is due to more COW copies occuring. It appears that I fixed all of the COW issues with a release stdlib (when client is compiled in Debug), but there may be additional COW copies when the stdlib is compiled in Debug mode. = /. Michael > > >> On Mar 18, 2017, at 11:48 AM, no-re...@swift.org <mailto:no-re...@swift.org> >> wrote: >> >> [FAILURE] oss-swift-incremental-ASAN-RA-osx [#212] >> >> Build URL: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/212/ >> <https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/212/> >> Project: oss-swift-incremental-ASAN-RA-osx >> Date of build: Sat, 18 Mar 2017 10:26:14 -0700 >> Build duration: 1 hr 22 min >> Identified problems: >> >> Assertion failure: This build failed because of an assertion failure. Below >> is a list of all errors in the build log: >> Indication 1 >> <https://ci.swift.org//job/oss-swift-incremental-ASAN-RA-osx/212/consoleFull#1684097467c38edd5a-00f9-40a2-abac-1db59f7a90ca> >> Changes >> >> Commit e52eea2199d8c23ceb82b6bbe85aeb341ccb0fa2 by Michael Gottesman: >> [silgen] When a formal evaluation scope is in an inout conversion scope, >> >> edit: lib/SILGen/FormalEvaluation.cpp >> edit: lib/SILGen/FormalEvaluation.h >> >> Commit 53eab13be8dd1202428af1b5c315f17c1ab02186 by Michael Gottesman: >> [silgen] Move foreignErrorPreparation code in ResultPlanBuilder into a >> >> edit: lib/SILGen/ResultPlan.cpp >> edit: lib/SILGen/ResultPlan.h >
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev
