* What is your evaluation of the proposal?

Strong assent.

* Is the problem being addressed significant enough to warrant a change to
Swift?

Lots of people have complained about heavily parameterized generic code
being difficult to read and rather scary looking in general. While this
proposal makes no changes to the expressiveness of the language, it
improves developer ergonomics and helps keep people's eyes from glazing
over when they try reading through such functions.

* Does this proposal fit well with the feel and direction of Swift?

No loss of expressive power, an improvement overall. (There is also a
pleasing symmetry with the 'where' clause syntax for protocol extensions.)
It feels more natural: the most important information (name, generic type
parameter decls, formal parameters, and return type/effects) are all
introduced to the reader before the subordinate constraint clause is
introduced with 'where'. Before, the angle brackets portion of a function
declaration could become a huge multi-line symbol-rich blob separating the
function name from the parameters/return type, making it harder to visually
parse.

* If you have used other languages or libraries with a similar feature, how
do you feel that this proposal compares to those?

I believe Rust does something similar. This is probably another advantage,
a tiny bit of friction removed from people who want to move between these
two languages.

* How much effort did you put into your review? A glance, a quick reading,
or an in-depth study?

Close reading of the proposal; followed along within the proposal thread.

Best,
Austin

On Tue, May 10, 2016 at 11:51 AM, Chris Lattner <clatt...@apple.com> wrote:

> Hello Swift community,
>
> The review of "SE-0081: Move where clause to end of declaration" begins
> now and runs through May 16. The proposal is available here:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0081-move-where-expression.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at
>
>         https://lists.swift.org/mailman/listinfo/swift-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager.
>
> What goes into a review?
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and contribute to the direction of Swift.
> When writing your review, here are some questions you might want to answer
> in your review:
>
>         * What is your evaluation of the proposal?
>         * Is the problem being addressed significant enough to warrant a
> change to Swift?
>         * Does this proposal fit well with the feel and direction of Swift?
>         * If you have used other languages or libraries with a similar
> feature, how do you feel that this proposal compares to those?
>         * How much effort did you put into your review? A glance, a quick
> reading, or an in-depth study?
>
> More information about the Swift evolution process is available at
>
>         https://github.com/apple/swift-evolution/blob/master/process.md
>
> Thank you,
>
> -Chris Lattner
> Review Manager
>
> _______________________________________________
> swift-evolution-announce mailing list
> swift-evolution-annou...@swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution-announce
>
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution

Reply via email to