* What is your evaluation of the proposal?
+1 from me. I particularly like how this adheres to the principle of least
surprise. Keeping == and != is an important part of the proposal, as others
have said.
* Is the problem being addressed significant enough to warrant a change to
Swift?
I believe so.
* Does this proposal fit well with the feel and direction of Swift?
Aye, pretty happy about its direction.
* If you have used other languages or libraries with a similar feature, how do
you feel that this proposal compares to those?
I have: Objective-C! Converting the code from the proposal, we have:
NSArray *ps = [peeps filter:^BOOL(Person *lhs, Person *rhs) {
return [[lhs pet] age] < [[rhs pet] age];
}];
I think that convention works in Objective-C, nil being capable of receiving
messages is a cornerstone of the language. But Swift has discouraged the
convention of calling functions directly on nil, through Optionals. I believe
that removing the comparison operators for Optionals adheres to the same ideas
that Optionals themselves are built from.
* How much effort did you put into your review? A glance, a quick reading, or
an in-depth study?
I read the review thoroughly, asked on Twitter, let it sit in the back of my
head for an hour. I also had to spend five minutes figuring out the Objective-C
block syntax for a filter function.
--
Ash Furrow
https://ashfurrow.com/
On July 12, 2016 at 2:26:55 PM, Chris Lattner via swift-evolution
(swift-evolution@swift.org) wrote:
Hello Swift community,
The review of "SE-0121: Remove `Optional` Comparison Operators" begins now and
runs through July 19. The proposal is available here:
https://github.com/apple/swift-evolution/blob/master/proposals/0121-remove-optional-comparison-operators.md
Reviews are an important part of the Swift evolution process. All reviews
should be sent to the swift-evolution mailing list at
https://lists.swift.org/mailman/listinfo/swift-evolution
or, if you would like to keep your feedback private, directly to the review
manager.
What goes into a review?
The goal of the review process is to improve the proposal under review through
constructive criticism and contribute to the direction of Swift. When writing
your review, here are some questions you might want to answer in your review:
* What is your evaluation of the proposal?
* Is the problem being addressed significant enough to warrant a change to
Swift?
* Does this proposal fit well with the feel and direction of Swift?
* If you have used other languages or libraries with a similar feature, how do
you feel that this proposal compares to those?
* How much effort did you put into your review? A glance, a quick reading, or
an in-depth study?
More information about the Swift evolution process is available at
https://github.com/apple/swift-evolution/blob/master/process.md
Thank you,
-Chris Lattner
Review Manager
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution
