> * What is your evaluation of the proposal? -1, I really think this a step in the wrong direction. I recognise the problem around this, and why something is needed. However, I don’t like the idea of restricting things by default. In the attempt to solve a problem, we will create more problems by introducing more workarounds to replace what now is being overridden.
> * Is the problem being addressed significant enough to warrant a change to > Swift? No. I think the defaults should not be changed, but restricting subclassing (and overriding) should be opt-in. > * Does this proposal fit well with the feel and direction of Swift? No. I think this kind of restrictions make Swift worst. > * If you have used other languages or libraries with a similar feature, how > do you feel that this proposal compares to those? This is the opposite of how other languages solves this kind of restrictions. > * How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? I read in-depth the updated proposal and most of the discussion. > On Jul 16, 2016, at 2:52 AM, Chris Lattner <clatt...@apple.com> wrote: > > Hello Swift community, > > The second review of "SE-0117: Default classes to be non-subclassable > publicly" begins now and runs through July 22. The proposal is available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0117-non-public-subclassable-by-default.md > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > > or, if you would like to keep your feedback private, directly to the review > manager. > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and contribute to the direction of Swift. When > writing your review, here are some questions you might want to answer in your > review: > > * What is your evaluation of the proposal? > * Is the problem being addressed significant enough to warrant a change > to Swift? > * Does this proposal fit well with the feel and direction of Swift? > * If you have used other languages or libraries with a similar feature, > how do you feel that this proposal compares to those? > * How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > More information about the Swift evolution process is available at > > https://github.com/apple/swift-evolution/blob/master/process.md > > Thank you, > > -Chris Lattner > Review Manager > > > _______________________________________________ > swift-evolution-announce mailing list > swift-evolution-annou...@swift.org > https://lists.swift.org/mailman/listinfo/swift-evolution-announce _______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution
