Proposal link: https://github.com/apple/swift-evolution/blob/master/ proposals/0188-stdlib-index-types-hashable.md
• What is your evaluation of the proposal? +1 but would like it to further and require all index types to be Hashable. • Is the problem being addressed significant enough to warrant a change to Swift? It has been a problem for me in the past, however just requiring the standard library ones to be hashable would solve the problem of third party libraries, therefore suggest all hashable. • Does this proposal fit well with the feel and direction of Swift? Yes, this is the sort of thing that needs finalising before ABI stability else we will be stuck with a problem. • If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those? Yes, Java, Scala, etc. Most languages have a hashable index so you can have a set on indices etc. • How much effort did you put into your review? A glance, a quick reading, or an in-depth study? Have read the review and have also implemented my own collections, which used hashable indices. -- Howard. On 9 November 2017 at 12:55, Ben Cohen via swift-evolution < swift-evolution@swift.org> wrote: > Hello, Swift community! > > The review of “SE-0188: Make stdlib index types Hashable” begins now and > runs through November 14th, 2017. The proposal is available here: > > https://github.com/apple/swift-evolution/blob/master/ > proposals/0188-stdlib-index-types-hashable.md > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > > > or, if you would like to keep your feedback private, directly to me as the > review manager. When replying, please try to keep the proposal link at the > top of the message: > > Proposal link: > https://github.com/apple/swift-evolution/blob/master/ > proposals/0188-stdlib-index-types-hashable.md > > Reply text > > Other replies > > *What goes into a review?* > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. > > When writing your review, here are some questions you might want to answer > in your review: > > • What is your evaluation of the proposal? > • Is the problem being addressed significant enough to warrant a change to > Swift? > • Does this proposal fit well with the feel and direction of Swift? > • If you have used other languages or libraries with a similar feature, > how do you feel that this proposal compares to those? > • How much effort did you put into your review? A glance, a quick reading, > or an in-depth study? > > More information about the Swift evolution process is available at: > > https://github.com/apple/swift-evolution/blob/master/process.md > > > As always, thank you for contributing to the evolution of Swift. > > Ben Cohen > Review Manager > > > > > _______________________________________________ > swift-evolution mailing list > swift-evolution@swift.org > https://lists.swift.org/mailman/listinfo/swift-evolution > >
_______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution
