Sure thing, sorry for the bother. On Thu, Dec 3, 2015 at 11:00 PM, Dmitri Gribenko <[email protected]> wrote:
> Thanks, Todd! > > On Thu, Dec 3, 2015 at 11:00 PM, Todd Fiala <[email protected]> wrote: > > Mishal, > > > > Reverted here: > > > > commit 02a493b8380bbcb5c4bf2e123db0b6d79c95dc8f (HEAD -> master, > > origin/master, origin/HEAD) > > Author: Todd Fiala <[email protected]> > > Date: Thu Dec 3 22:57:16 2015 > > > > > > You should be back in business. > > > > I'll re-introduce this change a more appropriate way in the morning. > > > > -Todd > > > > > > On Thu, Dec 3, 2015 at 10:56 PM, Todd Fiala <[email protected]> > wrote: > >> > >> Okay I think I see the issue. It is that we can still pass backdoor > >> combinations of build modes after the '--' in build-script that will > control > >> the final build variant used by lldb. > >> > >> The logic for this check doesn't belong in build-script, but rather > >> build-script-impl. build-script-impl is the only place to find the > final > >> build mode after considering both the values passed to build-script, and > >> other bits that can be passed along to build-script-impl. > >> > >> I'm going to revert my change and add a proper fix in the morning. I > >> don't have enough brain power to do it right and test it now. > >> > >> On Thu, Dec 3, 2015 at 10:51 PM, Todd Fiala <[email protected]> > wrote: > >>> > >>> Yep I finally added enough gunk to the command line to reproduce. > >>> > >>> I'm looking at how it's getting the Release value now. That's the > issue > >>> (I'm not seeing it come in as Release). > >>> > >>> On Thu, Dec 3, 2015 at 10:44 PM, Dmitri Gribenko <[email protected]> > >>> wrote: > >>>> > >>>> On Thu, Dec 3, 2015 at 10:41 PM, Todd Fiala <[email protected]> > >>>> wrote: > >>>> > I see. > >>>> > > >>>> > And I think I see the issue. It's trying to do a release-debuginfo > >>>> > build > >>>> > across the board. LLDB chokes on those. So we'll need to > explicitly > >>>> > set > >>>> > the lldb build variant to something different (either release or > >>>> > debug, > >>>> > likely release). > >>>> > >>>> The preset is trying to do that (lldb-build-type=Release), but > >>>> apparently is getting ignored. > >>>> > >>>> Dmitri > >>>> > >>>> -- > >>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if > >>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/ > >>> > >>> > >>> > >>> > >>> -- > >>> -Todd > >> > >> > >> > >> > >> -- > >> -Todd > > > > > > > > > > -- > > -Todd > > > > -- > main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if > (j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/ > -- -Todd
_______________________________________________ swift-lldb-dev mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-lldb-dev
