Just for those interested, this does not reproduce on a Linux host. This seems to be specific to a macOS host.
On Wed, Oct 4, 2017 at 11:00 AM Saleem Abdulrasool <[email protected]> wrote: > On Wed, Oct 4, 2017 at 10:57 AM Adrian Prantl <[email protected]> wrote: > >> >> On Oct 4, 2017, at 10:54 AM, Saleem Abdulrasool <[email protected]> >> wrote: >> >> Does the lldb test suite not run as part of the CI builds? >> >> >> AFAIK it is currently not running as part of pull request testing. (Which >> is obviously not ideal). >> > > Getting some minimal coverage would be nice. But I think that would be > outside of the scope of my changes. That can also be done subsequently to > improve coverage. > > >> >> It seems that in the mean time, at least two new regressions have been >> introduced into the Windows build. That does make me slightly hesistent >> since it seems that it is more likely that other regressions will get >> introduced. >> >> In any case, I’m doing a build of lldb and will look into this once the >> build completes. Hopefully the failures also reproduces on Linux. >> >> >> Thanks! Jim ([email protected]) should be able to help you with any >> LLDB-related questions. >> > > Awesome! I might have to take you up on that offer :) > > >> -- adrian >> >> >> Saleem >> >> On Wed, Oct 4, 2017 at 10:36 AM Adrian Prantl <[email protected]> wrote: >> >>> >>> On Oct 4, 2017, at 10:33 AM, Saleem Abdulrasool <[email protected]> >>> wrote: >>> >>> >>> On Wed, Oct 4, 2017 at 10:29 AM Jim Ingham <[email protected]> wrote: >>> >>>> Nothing significant has changed on the lldb side but we're getting a >>>> bunch of tests asserting here: >>>> >>>> 21:01:25 >>>> Assertion failed: (isTypeMetadata()), function getDescription, file >>>> /Users/buildslave/jenkins/workspace/lldb-master-tools_RA/swift/include/swift/Runtime/Metadata.h, >>>> line 1469. >>>> >>>> Anybody got any clues of what might have changed on the Swift side to >>>> start tripping this assertion? >>> >>> >>> The type metadata layout has changed. The value witness table reference >>> is no longer an offset but rather a complete pointer. >>> >>> It is possible that lldb needs to be updated for that? >>> >>> >>> That sounds plausible. Would it be possible to revert the commit until a >>> solution is found? You can easily build lldb by checking it out next to >>> swift and adding "-l" to the build script. >>> >>> -- adrian >>> >>> >>> >>>> Jim >>>> >>>> >>>> >>>> > On Oct 3, 2017, at 9:38 PM, [email protected] wrote: >>>> > >>>> > [FAILURE] oss-lldb-incremental-osx [#230] >>>> > >>>> > Build URL: https://ci.swift.org/job/oss-lldb-incremental-osx/230/ >>>> > Project: oss-lldb-incremental-osx >>>> > Date of build: Tue, 03 Oct 2017 22:55:41 -0500 >>>> > Build duration: 43 min >>>> > Identified problems: >>>> > >>>> > • Regression test failed: This build failed because a >>>> regression test in the test suite FAILed. Below is a list of all errors: >>>> > • Indication 1 >>>> > • Assertion failure: This build failed because of an assertion >>>> failure. Below is a list of all errors in the build log: >>>> > • Indication 1 >>>> > >>>> > Changes >>>> > >>>> > • Commit 99e395b7e3f89b1f6f2874296a37add58aece6d6 by github: >>>> > [APINotes] Add 'RetainCountConvention' (#133) >>>> > >>>> > • edit: include/clang/APINotes/Types.h >>>> > • edit: lib/APINotes/APINotesWriter.cpp >>>> > • edit: test/APINotes/Inputs/roundtrip.apinotes >>>> > • edit: lib/APINotes/APINotesYAMLCompiler.cpp >>>> > • edit: lib/APINotes/APINotesReader.cpp >>>> > • add: test/APINotes/retain-count-convention.m >>>> > • edit: >>>> test/APINotes/Inputs/Frameworks/SimpleKit.framework/Headers/SimpleKit.h >>>> > • edit: lib/Sema/SemaAPINotes.cpp >>>> > • edit: test/APINotes/yaml-roundtrip.c >>>> > • edit: >>>> test/APINotes/Inputs/Frameworks/SimpleKit.framework/Headers/SimpleKit.apinotes >>>> > >>>> > • Commit 969421f5ac164d98f4650ae0f1a4fd10409cabad by aprantl: >>>> > [DebugInfo] Handle endianness when moving debug info for split integer >>>> > >>>> > • edit: lib/CodeGen/SelectionDAG/LegalizeTypes.cpp >>>> > • add: test/CodeGen/PowerPC/debuginfo-split-int.ll >>>> > >>>> > • Commit e77f221279851c2406e824e75ae8904ba7d89ab5 by aprantl: >>>> > Add a manpage for llvm-dwarfdump. >>>> > >>>> > • edit: docs/CMakeLists.txt >>>> > • edit: docs/CommandGuide/llvm-dwarfdump.rst >>>> > >>>> > • Commit 2850e656c89ac7c4837a01b57c52c036e88c81f7 by jingham: >>>> > This test is passing everywhere I can see, so I'm removing the xfail, >>>> to >>>> > >>>> > • edit: >>>> packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py >>>> > >>>> > • Commit 7e6b564bf551e1ccd4eaff2824d87dd89b71a686 by dgregor: >>>> > Add fixed crasher from rdar://problem/33575781 >>>> > >>>> > • add: >>>> validation-test/compiler_crashers_2_fixed/0125-rdar33575781.swift >>>> > >>>> > • Commit 086c12114dfdff1b7b7179a6052f43a8d73557ed by compnerd: >>>> > IRGen: switch to absolute pointers for nominal type descriptors >>>> > >>>> > • edit: include/swift/Runtime/Metadata.h >>>> > • edit: lib/IRGen/ConstantBuilder.h >>>> > • edit: stdlib/public/runtime/Metadata.cpp >>>> > • edit: unittests/runtime/Metadata.cpp >>>> > • edit: lib/IRGen/GenMeta.cpp >>>> > • edit: stdlib/public/runtime/ProtocolConformance.cpp >>>> > • edit: test/IRGen/foreign_types.sil >>>> > • edit: test/IRGen/objc_attr_NSManaged.sil >>>> > • edit: include/swift/Remote/MetadataReader.h >>>> > • edit: stdlib/public/runtime/Casting.cpp >>>> > • edit: test/IRGen/field_type_vectors.sil >>>> > >>>> > • Commit 2645a6a4b9cf2df212da6db9a41b3363ff44de56 by dgregor: >>>> > [Deserialization] Configure protocol before loading requirement >>>> > >>>> > • add: test/Serialization/recursive_protocol_merge.swift >>>> > • add: >>>> test/Serialization/Inputs/recursive_protocol_merge_b.swift >>>> > • add: >>>> test/Serialization/Inputs/recursive_protocol_merge_a.swift >>>> > • edit: lib/Serialization/Deserialization.cpp >>>> > >>>> > • Commit 610aa582ce9647ad377812355d8ae36ec5cf0e31 by shajrawi: >>>> > Fixes (another) IRGen compiler crash caused by the new large types ABI >>>> > >>>> > • edit: test/IRGen/big_types_corner_cases.sil >>>> > • edit: lib/IRGen/LoadableByAddress.cpp >>>> > >>>> > • Commit 77554c1ae2b3b2de16b803409d9f7085ad186562 by ghoare: >>>> > [Stats] Fix typo. >>>> > >>>> > • edit: lib/Basic/Statistic.cpp >>>> > >>>> > • Commit 0e5b982d2561bc7c102e2abe984e19241735aaa2 by ghoare: >>>> > [Stats] Only use input filename, not mangled path, in stats file name. >>>> > >>>> > • edit: lib/Basic/Statistic.cpp >>>> > >>>> > • Commit c1a4bb490bcdf8d20c962ab43249eaee44ee037f by github: >>>> > [test] Define out part of this test that's crashing on Linux (#12258) >>>> > >>>> > • edit: test/ClangImporter/clang_builtins.swift >>>> >>>> -- >>> Saleem Abdulrasool >>> compnerd (at) compnerd (dot) org >>> >>> -- >> Saleem Abdulrasool >> compnerd (at) compnerd (dot) org >> >> -- > Saleem Abdulrasool > compnerd (at) compnerd (dot) org > -- Saleem Abdulrasool compnerd (at) compnerd (dot) org
_______________________________________________ swift-lldb-dev mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-lldb-dev
