Hi Florian,

Hi Pavel!

As you remember I'm working on adding generics to the Swing-framework. To see if I introduce new warnings while working on this task (especially unchecked and cast warnings) I need to reduce the number of warnings in the Swing-project first.

I cloned the following repository: http://hg.openjdk.java.net/jdk7/jdk7/jdk
Is this correct?
Yes.

When compiling with -Xlint -J-Xms80m -J-Xmx256m -Xlint:-serial -Xlint:-deprecation -Xlint:-fallthrough -Xmaxwarns 2300
this patch reduces the number of reported warnings from 1277 to 1262.
Your patch looks good. I've only one notice: we don't use "TAB" characters in our sources. Can you remove all TABs from your fix?

The basis of this patch is the changeset 99a06bc7fdb5. It has been created with 'hg diff'. NetBeans' 'Tools->Apply Diff Patch' does not work unfortunatly but 'hg import' should work.

And now: Happy New Year! :-)
Thanks. Our holidays finished a couple days ago. Sorry for delay...

Pavel.

Reply via email to