Re: [PATCH] 6179357: Generics: JList

[Florian Brunner]

Hi Alexander,

Hello Florian

Hi Pavel, hi Alexander,

I'm back from holiday.

Wow, how was the vacation?

Thanks for asking, I spent some nice days in Poland. :-)

What is the status of this patch? Any news?

I sent some comments about your recent patch to Pavel

Tomorrow, we'll come back to this issue again.
He is going to send an update to you.

Great.

Thanks.
-Florian

Thanks
alexp

-Florian

Alexander Potochkin schrieb:

Hello Florian

Great! :-)

In the case of other issues please note that I'm on holiday until the end of next week.

Have a nice holiday!

(I am reviewing the fix right now)

Thanks
alexp

-Florian

Pavel Porvatov schrieb:

Hi Florian,

Hi Pavel,

I agree that we should avoid to mix several different fixes in one fix, but since in this fix we change

AbstractListModel to AbstractListModel<E>
and
JList(ListModel dataModel) to JList(ListModel<E> dataModel)

I think we should also change usages of AbstractListModel such as "this (new AbstractListModel()...)" to "this (new AbstractListModel<E>()...)" to avoid warnings.

Ok, then it will not be a problem. Let's include this change in your fix. Therefore all my comments are gone and I'm going to start our internal process to commit your fix.

Thanks, Pavel.

If you don't agree:

There are several places where I changed the usage of now generified classes to the generic variant. Which ones should I change back? Only this case?