Re: Fwd: The file list in JFileChooser does not have an accessible name.

Sun, 04 Sep 2011 19:43:45 -0700 

On 09/02/2011 06:41 PM, Pavel Porvatov wrote:

Hi Charles,

On 09/01/2011 08:37 PM, Pavel Porvatov wrote:

Hi Charles,

On 08/25/2011 05:45 PM, Pavel Porvatov wrote:



putClientProperty still does not work on my side. I can not find 
methods which receive the accessible property changes. Is the diff 
attached you supposed to be?

Take a look at 
javax.swing.JComponent.AccessibleJComponent#getAccessibleName


...
            if (name == null) {

                name = 
(String)getClientProperty(AccessibleContext.ACCESSIBLE_NAME_PROPERTY);

            }
...


Below is FilePane patch that works on my PC:

# hg diff src/share/classes/sun/swing/FilePane.java

diff --git a/src/share/classes/sun/swing/FilePane.java 
b/src/share/classes/sun/swing/FilePane.java

--- a/src/share/classes/sun/swing/FilePane.java
+++ b/src/share/classes/sun/swing/FilePane.java
@@ -35,6 +35,7 @@
 import java.util.List;
 import java.util.concurrent.Callable;

+import javax.accessibility.AccessibleContext;
 import javax.swing.*;
 import javax.swing.border.*;
 import javax.swing.event.*;
@@ -82,6 +83,8 @@
     private JPanel currentViewPanel;
     private String[] viewTypeActionNames;

+    private String filesListAccessibleName = null;
+
     private JPopupMenu contextMenu;
     private JMenu viewMenu;

@@ -450,6 +453,8 @@

         gigaByteString = 
UIManager.getString("FileChooser.fileSizeGigaBytes", l);
         fullRowSelection = 
UIManager.getBoolean("FileView.fullRowSelection");



+        filesListAccessibleName = 
UIManager.getString("FileChooser.filesListAccessibleName",l);

+

         renameErrorTitleText = 
UIManager.getString("FileChooser.renameErrorTitleText", l);
         renameErrorText = 
UIManager.getString("FileChooser.renameErrorText", l);
         renameErrorFileExistsText = 
UIManager.getString("FileChooser.renameErrorFileExistsText", l);

@@ -634,6 +639,9 @@
         if (listViewBorder != null) {
             scrollpane.setBorder(listViewBorder);
         }
+

+        
list.putClientProperty(AccessibleContext.ACCESSIBLE_NAME_PROPERTY, 
filesListAccessibleName);

+
         p.add(scrollpane, BorderLayout.CENTER);
         return p;
     }

I used attached test for checking...

Regards, Pavel

Great, it works, though I do not know why it does not work before....

So, Pavel my question is still there:


I do not get "There is no AccessibleDescription for all resources". 
Do you mean it is not in all the resource file (*.properties) or do 
you mean not all accessible class has accessible description?

I meant that we don't add accessible descriptions, therefore I'd like 
to remove FileChooser.filesAccessibleDescription from the patch.


Regards, Pavel

Ok. So the new patch goes to (attached):


--
Yours Charles


diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties
index 109538a..1ce3ee5 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties
@@ -91,6 +91,8 @@ FileChooser.updateButtonToolTipText=Update directory listing
 FileChooser.helpButtonToolTipText=FileChooser help
 FileChooser.directoryOpenButtonToolTipText=Open selected directory
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=Preview
 ColorChooser.okText=OK
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties
index 2306682..045460d 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties
@@ -90,6 +90,8 @@ FileChooser.updateButtonToolTipText=Verzeichnisliste 
aktualisieren
 FileChooser.helpButtonToolTipText=FileChooser-Hilfe
 FileChooser.directoryOpenButtonToolTipText=Ausgew\u00E4hltes Verzeichnis 
\u00F6ffnen
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=Vorschau
 ColorChooser.okText=OK
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties
index 09b72da..4d3542f 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties
@@ -90,6 +90,8 @@ FileChooser.updateButtonToolTipText=Actualizar lista de 
directorios
 FileChooser.helpButtonToolTipText=Ayuda del Selector de Archivos
 FileChooser.directoryOpenButtonToolTipText=Abrir directorio seleccionado
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=Presentaci\u00F3n Preliminar
 ColorChooser.okText=Aceptar
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties
index 8b3ba8f..f6f7680 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties
@@ -90,6 +90,8 @@ FileChooser.updateButtonToolTipText=Met \u00E0 jour la liste 
des r\u00E9pertoire
 FileChooser.helpButtonToolTipText=Aide du s\u00E9lecteur de fichiers
 FileChooser.directoryOpenButtonToolTipText=Ouvre le r\u00E9pertoire 
s\u00E9lectionn\u00E9
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=Aper\u00E7u
 ColorChooser.okText=OK
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties
index e4c23c7..579bc64 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties
@@ -90,6 +90,8 @@ FileChooser.updateButtonToolTipText=Aggiorna la lista 
directory
 FileChooser.helpButtonToolTipText=Guida FileChooser
 FileChooser.directoryOpenButtonToolTipText=Apre la directory selezionata
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=Anteprima
 ColorChooser.okText=OK
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties
index 7b94641..cfc46a7 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties
@@ -90,6 +90,8 @@ 
FileChooser.updateButtonToolTipText=\u30C7\u30A3\u30EC\u30AF\u30C8\u30EA\u306E\u
 
FileChooser.helpButtonToolTipText=FileChooser\u306E\u30D8\u30EB\u30D7\u3067\u3059
 
FileChooser.directoryOpenButtonToolTipText=\u9078\u629E\u3057\u305F\u30C7\u30A3\u30EC\u30AF\u30C8\u30EA\u3092\u958B\u304D\u307E\u3059
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=\u30D7\u30EC\u30D3\u30E5\u30FC
 ColorChooser.okText=OK
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties
index 8dd3f17..4e22eb7 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties
@@ -90,6 +90,8 @@ FileChooser.updateButtonToolTipText=\uB514\uB809\uD1A0\uB9AC 
\uBAA9\uB85D \uAC31
 FileChooser.helpButtonToolTipText=FileChooser \uB3C4\uC6C0\uB9D0
 FileChooser.directoryOpenButtonToolTipText=\uC120\uD0DD\uB41C 
\uB514\uB809\uD1A0\uB9AC \uC5F4\uAE30
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=\uBBF8\uB9AC\uBCF4\uAE30
 ColorChooser.okText=\uD655\uC778
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties
index cbc3c99..74d5599 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties
@@ -90,6 +90,8 @@ FileChooser.updateButtonToolTipText=Atualizar lista de 
diret\u00F3rios
 FileChooser.helpButtonToolTipText=Ajuda do FileChooser
 FileChooser.directoryOpenButtonToolTipText=Abrir diret\u00F3rio selecionado
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=Visualizar
 ColorChooser.okText=OK
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties
index c28dfbd..e5b1b6a 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties
@@ -90,6 +90,8 @@ FileChooser.updateButtonToolTipText=Uppdatera kataloglistan
 FileChooser.helpButtonToolTipText=Hj\u00E4lp - Filv\u00E4ljare
 FileChooser.directoryOpenButtonToolTipText=\u00D6ppna vald katalog
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=Granska
 ColorChooser.okText=OK
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties
index bb9a6ca..cd97a01 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties
@@ -90,6 +90,8 @@ 
FileChooser.updateButtonToolTipText=\u66F4\u65B0\u76EE\u5F55\u5217\u8868
 FileChooser.helpButtonToolTipText=FileChooser \u5E2E\u52A9
 
FileChooser.directoryOpenButtonToolTipText=\u6253\u5F00\u9009\u62E9\u7684\u76EE\u5F55
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=\u9884\u89C8
 ColorChooser.okText=\u786E\u5B9A
diff --git 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties
 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties
index 24b5503..1daf2f9 100644
--- 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties
+++ 
src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties
@@ -90,6 +90,8 @@ 
FileChooser.updateButtonToolTipText=\u66F4\u65B0\u76EE\u9304\u6E05\u55AE
 
FileChooser.helpButtonToolTipText=\u300C\u6A94\u6848\u9078\u64C7\u5668\u300D\u8AAA\u660E
 
FileChooser.directoryOpenButtonToolTipText=\u958B\u555F\u9078\u53D6\u7684\u76EE\u9304
 
+FileChooser.filesListAccessibleName=Files List
+
 ############ COLOR CHOOSER STRINGS #############
 ColorChooser.previewText=\u9810\u89BD
 ColorChooser.okText=\u78BA\u5B9A
diff --git src/share/classes/sun/swing/FilePane.java 
src/share/classes/sun/swing/FilePane.java
index 9a95220..064cca2 100644
--- src/share/classes/sun/swing/FilePane.java
+++ src/share/classes/sun/swing/FilePane.java
@@ -35,6 +35,7 @@ import java.util.*;
 import java.util.List;
 import java.util.concurrent.Callable;
 
+import javax.accessibility.AccessibleContext;
 import javax.swing.*;
 import javax.swing.border.*;
 import javax.swing.event.*;
@@ -82,6 +83,8 @@ public class FilePane extends JPanel implements 
PropertyChangeListener {
     private JPanel currentViewPanel;
     private String[] viewTypeActionNames;
 
+    private String filesListAccessibleName = null;
+
     private JPopupMenu contextMenu;
     private JMenu viewMenu;
 
@@ -450,6 +453,8 @@ public class FilePane extends JPanel implements 
PropertyChangeListener {
         gigaByteString = UIManager.getString("FileChooser.fileSizeGigaBytes", 
l);
         fullRowSelection = UIManager.getBoolean("FileView.fullRowSelection");
 
+        filesListAccessibleName = 
UIManager.getString("FileChooser.filesListAccessibleName", l);
+
         renameErrorTitleText = 
UIManager.getString("FileChooser.renameErrorTitleText", l);
         renameErrorText = UIManager.getString("FileChooser.renameErrorText", 
l);
         renameErrorFileExistsText = 
UIManager.getString("FileChooser.renameErrorFileExistsText", l);
@@ -634,6 +639,10 @@ public class FilePane extends JPanel implements 
PropertyChangeListener {
         if (listViewBorder != null) {
             scrollpane.setBorder(listViewBorder);
         }
+
+        /* Setting accessible name for File List in JFileChooser */
+        list.putClientProperty(AccessibleContext.ACCESSIBLE_NAME_PROPERTY, 
filesListAccessibleName);
+
         p.add(scrollpane, BorderLayout.CENTER);
         return p;
     }



























					Reply via email to