On 04/19/2012 11:57 PM, Pavel Porvatov wrote:
Hi Charles,
See my comment at the end...
On 04/16/2012 12:33 PM, Sean Chou wrote:
Hi Pavel,
Modified and tested on windows and linux.
webrev at http://cr.openjdk.java.net/~zhouyx/7129742/webrev.07/
<http://cr.openjdk.java.net/%7Ezhouyx/7129742/webrev.07/>
On Sun, Apr 15, 2012 at 5:31 PM, Pavel Porvatov
<pavel.porva...@oracle.com <mailto:pavel.porva...@oracle.com>> wrote:
Hi Sean,
Hi Pavel,
I modified the testcase according to your comments. The
webrev is http://cr.openjdk.java.net/~zhouyx/7129742/webrev.06/
<http://cr.openjdk.java.net/%7Ezhouyx/7129742/webrev.06/> .
Please take a look again.
And now when fastreturn is true the test doesn't stop.
Regards, Pavel
On Thu, Apr 12, 2012 at 10:24 PM, Pavel Porvatov
<pavel.porva...@oracle.com <mailto:pavel.porva...@oracle.com>>
wrote:
Hi Sean,
The fix looks good, but I have several comments about the test:
1. You shouldn't use Swing components on non-EDT threads,
so frame.dispose() should be done on the EDT
I made a really stupid mistake... When I was checking the
testcase and found frame.dispose() in main method, I added a
volatile to the frame variable...
2. "These exceptions mean the implementation of
XTextAreaPeer is changed" - I think is XTextAreaPeer is
changed, then the test should be fixed as well or removed
(if the test become inapplicable. Therefore in that
situation the test should fail but not skipped
Regards, Pavel
--
Best Regards,
Sean Chou
--
Best Regards,
Sean Chou
Hi Sean,
The patch is committed @
Changeset: 4828ffa1f5ee
Author: zhouyx
Date: 2012-04-17 13:31 +0800
URL:http://hg.openjdk.java.net/jdk8/swing/jdk/rev/4828ffa1f5ee
7129742: Unable to view focus in Non-Editable TextArea
Summary: Make sure the cursor is visible by setVisible(true)
Reviewed-by: rupashka, alexp
Please verify it and thanks all for reviewing the patch.
Unfortunately you put the change in a legacy repository. You must use
awt repository for Swing and AWT fixes. Could you please re-push the
fix in the http://hg.openjdk.java.net/jdk8/awt/jdk repository?
Regards, Pavel
Hi Pavel,
I have recommit the patch @
Changeset: 44beb8a52aec
Author: zhouyx
Date: 2012-04-20 10:34 +0800
URL:http://hg.openjdk.java.net/jdk8/awt/jdk/rev/44beb8a52aec
7129742: Unable to view focus in Non-Editable TextArea
Summary: Make sure the cursor is visible by setVisible(true)
Reviewed-by: rupashka, alexp
Thank you very much.
--
Yours Charles
