Hi Alexander,
The fix looks good.
Regards, Pavel
Hello,
Could you review the updated version of the fix:
http://cr.openjdk.java.net/~alexsch/7024963/webrev.01/
1) "catch (Throwable e)" is replaced by checking on null in the
constructor and removed from the main method.
2) Keys are moved from the properties file to the code as arrays.
However the system.properties file is still used for the
ViewportBackingStore property and for the Action values.
3) Unused methods and variables are removed
4) Imports are refactored
5) "for" loops are changed to "for each" loops
Thanks,
Alexandr.
On 4/27/2012 7:12 PM, Pavel Porvatov wrote:
Hi Alexander,
That's a bad practice to use "catch (Throwable e)" and we should
avoid that. There are a lot reasons, here is one of them:
http://www.javatuning.com/why-catch-throwable-is-evil-real-life-story/
Why can't we inline all nonlocalizable strings? After that the
"tokenize" method can be removed, I believe...
Regards, Pavel
Hello,
This is a request to review the fix for the issue:
7024963 Notepad demo: remove non-translatable resources from
Notepad.properties file
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7024963
The webrev is http://cr.openjdk.java.net/~alexsch/7024963/webrev.00
The non-translatable properties are moved to the file
system.properties.
The getProperty() method is used now instead of the
getResourceString() where non-translatable resources are used.
Thanks,
Alexandr.
