On 6/7/2012 4:43 PM, Pavel Porvatov wrote:
Hi Alexander,
I agree with all the fix except the following change:
- getDelegate().putClientProperty("JPasswordField.cutCopyAllowed",
- getDelegate().echoCharIsSet()
- ? Boolean.FALSE : Boolean.TRUE);
+ final boolean cutCopyAllowed;
+ final String focusInputMapKey;
+ if (echoChar != 0) {
Why getDelegate().echoCharIsSet() is replaced by "echoChar != 0"?
It seems that there is no any reason to use the "echoChar != 0"
instead of the getDelegate().echoCharIsSet().
Could you review the updated fix.
The only changes are using the getDelegate().echoCharIsSet()
instead of the "echoChar != 0".
http://cr.openjdk.java.net/~alexsch/7147078/webrev.00/
Thanks,
Alexandr.
Regards, Pavel
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147078
changeset:
http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/4bf554db8ed9
webrev: http://cr.openjdk.java.net/~alexp/7147078/webrev.00/
This is a forward port of the issue which has not been automatically
ported from the JDK 7u4 to JDK 8.
The code changes for JDK 8 are identical to the ones in JDK 7u4.
The issue is not reproduced in the JDK 8 with the applied patch.
Thanks,
Alexandr.
