I've applied the patch the current contents of the client repo:

    http://cr.openjdk.java.net/~darcy/8034169.1/

The patch applied unchanged except for in file MetalFileChooserUI.java.

-Joe

On 02/13/2014 10:31 AM, Phil Race wrote:
Hello. I think I must reject this change until it is re-submitted against the client repo.
It is NOT approved by the client team for pushing to dev.

-phil.

On 2/13/2014 12:00 AM, Joe Darcy wrote:
Hello,

Please review the largely tedious but straightforward fix for

    JDK-8034169: Fix serial lint warnings in javax.swing
    http://cr.openjdk.java.net/~darcy/8034169.0/

With the change, all of java.swing and it subclasses compile cleanly with the lint warning enabled.

Generally the serial warnings were address by an @SuppressWarnings("serial") annotation; the annotation included a comment about the justification for the suppressions.

In a small percentage of cases, a serialVersionUID field was added. When such a field was added, the serialver computation was checked for consistency on JDK6 and JDK 8.

(Note that the javax.swing.text.html.parser.Element type has actually different serialVersionUIDs on JDK 6 and 8.)

Thanks,

-Joe


Reply via email to