Approved: [9] Review request for 8034955 JLabel/JToolTip throw ClassCastException for "a"</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=swing-dev@openjdk.java.net&q=from:%22sergey+malenkov%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">sergey malenkov</span></span></a></span> <span class="date"><a href="/search?l=swing-dev@openjdk.java.net&q=date:20140304" rel="nofollow">Tue, 04 Mar 2014 06:21:07 -0800</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre style="margin: 0em;"> The fix looks good to me. SAM</pre><pre> On 03.03.2014 17:24, Alexander Scherbatiy wrote: </pre><blockquote style="border-left: #5555EE solid 0.2em; margin: 0em; padding-left: 0.85em"><pre style="margin: 0em;"> Hello, Could you review the fix: bug: <a rel="nofollow" href="https://bugs.openjdk.java.net/browse/JDK-8034955">https://bugs.openjdk.java.net/browse/JDK-8034955</a> webrev: <a rel="nofollow" href="http://cr.openjdk.java.net/~alexsch/8034955/webrev.00">http://cr.openjdk.java.net/~alexsch/8034955/webrev.00</a> The missed 'instanceof check' is added in the fix. Thanks, Alexandr. </pre></blockquote><pre style="margin: 0em;"> </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg03226.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="thrd3.html#03227">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="mail3.html#03227">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg03228.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email"><span class="subject"><a href="msg03226.html"><Swing Dev> [9] Review request for 8034955 JLab...</a></span> <span class="sender italic">Alexander Scherbatiy</span></li> <li><ul> <li class="icons-email tSliceCur"><span class="subject"><Swing Dev> Approved: [9] Review request f...</span> <span class="sender italic">sergey malenkov</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg03228.html">Re: <Swing Dev> Approved: [9] Review r...</a></span> <span class="sender italic">Petr Pchelko</span></li> </ul> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="<Swing Dev> Approved: [9] Review request for 8034955 JLabel/JToolTip throw ClassCastException for "<html>a<title>""> <input type="hidden" name="msgid" value="5315E0F5.1020008@oracle.com"> <input type="hidden" name="relpath" value="swing-dev@openjdk.java.net/msg03227.html"> <input type="submit" value=" sergey malenkov "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="swing-dev@openjdk.java.net"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search swing-dev"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/swing-dev@openjdk.java.net/">swing-dev - all messages</a></li> <li class="icons-about"><a href="/swing-dev@openjdk.java.net/info.html">swing-dev - about the list</a></li> <li class="icons-expand"><a href="/search?l=swing-dev@openjdk.java.net&q=subject:%22%3CSwing+Dev%3E+Approved%5C%3A+%5C%5B9%5C%5D+Review+request+for+8034955+JLabel%5C%2FJToolTip+throw+ClassCastException+for+%5C%22%3Chtml%3Ea%3Ctitle%3E%5C%22%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg03226.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg03228.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">5315E0F5.1020008@oracle.com</li> </ul> </div> </body> </html> <script>(function(){function c(){var b=a.contentDocument||a.contentWindow.document;if(b){var d=b.createElement('script');d.innerHTML="window.__CF$cv$params={r:'9a8a6bb11bc383b9',t:'MTc2NDg0MjA0OA=='};var a=document.createElement('script');a.src='/cdn-cgi/challenge-platform/scripts/jsd/main.js';document.getElementsByTagName('head')[0].appendChild(a);";b.getElementsByTagName('head')[0].appendChild(d)}}if(document.body){var a=document.createElement('iframe');a.height=1;a.width=1;a.style.position='absolute';a.style.top=0;a.style.left=0;a.style.border='none';a.style.visibility='hidden';document.body.appendChild(a);if('loading'!==document.readyState)c();else if(window.addEventListener)document.addEventListener('DOMContentLoaded',c);else{var e=document.onreadystatechange||function(){};document.onreadystatechange=function(b){e(b);'loading'!==document.readyState&&(document.onreadystatechange=e,c())}}}})();</script>