Hello Anton

Looks good!

Thanks
alexp

On 5/15/2014 1:06 PM, Anton Litvinov wrote:
Hello,

Could you please review the following fix for the bug.

Bug: https://bugs.openjdk.java.net/browse/JDK-8041725
Webrev: http://cr.openjdk.java.net/~alitvinov/8041725/jdk9/webrev.00

The bug consists in the fact that Nimbus L&F sets "selectionForeground" and "selectionBackground" colors of "javax.swing.JList" component to the colors which are not instances of "javax.swing.plaf.UIResource" interface, what makes these colors persist after change to other L&F.

The fix removes "uiResource="false"" attributes from the tags in the file "jdk/src/share/classes/javax/swing/plaf/nimbus/skin.laf" which declare the selection colors for various styles of "JList" component. This change lets these colors become instances of "javax.swing.plaf.nimbus.DerivedColor.UIResource" implementing "UIResource" interface.

Thank you,
Anton

Reply via email to