BasicButtonListener.checkOpacity - I think the doc is to detailed. You basically 
write how the method works and it prevents us prom changing it in the future. Also 
it's overridden in Metal L&F and it does a different thing there. Could you 
please come up with some less detailed description.

I cannot find the overriden method Metal L&F. But what should I write here?
"Checks an opacity of the {@code AbsractButton}."?

Andrei

On 07/09/2014 04:22 PM, Petr Pchelko wrote:
Hello, Andrei.

BasicButtonListener.checkOpacity - I think the doc is to detailed. You basically 
write how the method works and it prevents us prom changing it in the future. Also 
it's overridden in Metal L&F and it does a different thing there. Could you 
please come up with some less detailed description.

BasicComboBoxRenderer - the constructor doc is too detailed.

BasicGraphicsUtils:55 - type ethecd

BasicHTML:188 - wrong indentation

BasicPopupMenuUI:225 - dot needed.

BasicSeparatorUI:49 - dot needed.

With best regards. Petr.

On 09 июля 2014 г., at 16:02, andrei.eremeev <[email protected]> wrote:

Hi Swing team,

Please, review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8043968

The fix is available at:
http://cr.openjdk.java.net/~yan/8043968/

Andrei

Reply via email to