Alexandr,
The fix looks good. The root cause of this error is that mouseExited is not fired on the focused container when a modal dialog is shown. I'm surprised that there isn't a linked issue against AWT to either fix the toolkit to fire the mouseExited (via the Z axis) on modal dialog, suppress the 2nd call to mouseEntered after dialog is closed, or fix the MousListener documentation to state that how the mouse cursor enters or leaves a component has some exceptional conditions. My preference would be to fire mouseExited on modal dialog shown. Jason ---------------------------------------- > Date: Mon, 15 Dec 2014 15:24:51 +0300 > From: [email protected] > To: [email protected] > CC: [email protected] > Subject: Re: <Swing Dev> [9] Review request for 6219960 null reference in > ToolTipManager > > > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/6219960/webrev.01/ > > - The test has been added > > Thanks, > Alexandr. > > On 7/28/2014 5:37 PM, Sergey Bylokhov wrote: >> Hi, Alexander. >> What about the test? I see that it was added to the bug comment. >> >> On 7/28/14 6:20 PM, Alexander Scherbatiy wrote: >>> >>> Hello, >>> >>> Could you review the fix: >>> bug: https://bugs.openjdk.java.net/browse/JDK-6219960 >>> webrev: http://cr.openjdk.java.net/~alexsch/6219960/webrev.00 >>> >>> >>> The NPE is fixed. >>> >>> Thanks, >>> Alexandr. >>> >> >> >
