Hi Anton,
On 4/15/2015 8:14 AM, Anton V. Tarasov wrote:
Hi Joe,
(Looking into DefaultFocusManager.java)
Formally, the @return description is not good here:
+ /**
+ * Compare the components.
+ * @param a the first component
+ * @param b the second component
+ * @return the result of comparing the components
+ */
public boolean compareTabOrder(Component a, Component b) {
return (comparator.compare(a, b) < 0);
}
because not the components are compared for equality but their order
in a focus traversal cycle.
Okay; I'll push the change with the more accurate comment:
/**
* Compares the components by their focus traversal cycle order.
* @param a the first component
* @param b the second component
* @return a comparison of the components by their focus traversal
cycle order
*/
(Also, just a remark. The swing's FocusManager and DefaultFocusManager
classes are obsolete since JDK 1.4, they're not used any longer actually.)
I won't tackle the issue myself, but it sounds like marking such classes
as obsolete / deprecated would be a good cleanup for later in JDK 9.
Thanks for the review,
-Joe
Regards,
Anton.
On 14.04.2015 21:02, Sergey Bylokhov wrote:
HI, Joe.
The fix looks good. But it will be good if Anton(CC) will take a look
to the documentation of DefaultFocusManager.java
On 10.04.15 4:22, joe darcy wrote:
ping
Any comments or objections to this fix?
-Joe
On 4/7/2015 2:32 PM, joe darcy wrote:
Hello,
Please review changes to address
JDK-8075082: Fix missing doclint warnings in the javax.swing
package
http://cr.openjdk.java.net/~darcy/8075082.0/
Thanks,
-Joe
