Looks fine.
On 17.08.15 14:05, nadeesh tv wrote:
Hi all,
Gentle reminder
Regards,
Nadeesh
On 8/12/2015 1:33 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 8/12/2015 10:46 AM, nadeesh tv wrote:
Hi,
Please review the updated webrev links
open- http://cr.openjdk.java.net/~sgupta/8017187/webrev.02/
closed- http://cr.openjdk.java.net/~sgupta/8017187/webrev.03/
Thanks and Regards,
Nadeesh TV
On 8/11/2015 4:54 PM, nadeesh tv wrote:
Hi,
Please review the updated webrev links
closed - http://cr.openjdk.java.net/~sgupta/8017187/webrev.01/
open - http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/
Thanks and Regards,
Nadeesh TV
On 8/6/2015 8:13 PM, nadeesh tv wrote:
Hi,
Please review the updated webrev links
closed - http://cr.openjdk.java.net/~sgupta/8017187/webrev.01/
open - http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/
Thanks and Regards,
Nadeesh TV
On 8/5/2015 9:04 PM, Alexander Scherbatiy wrote:
On 8/5/2015 5:05 PM, nadeesh tv wrote:
HI all,
Please review the updated webrev links
closed - http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/
open - http://cr.openjdk.java.net/~sgupta/8017187/webrev.01/
- the patch does not contain the html file as it expected but
it still is shown on the provided open link. It seems that the
index.html file has not been updated.
- the swing calls like "!menu.isSelected()" should be invoked
on EDT.
Thanks,
Alexandr.
Thanks and Regards,
Nadeesh TV
On 7/29/2015 3:38 PM, Alexander Scherbatiy wrote:
- It looks like the html file has been used only because the
test was manual and it can be simply removed.
- Is it possible to use a robot to press keys rather than put
KeyEvents directly to the SystemEventQueue?
Thanks,
Alexandr.
On 7/24/2015 9:13 PM, nadeesh tv wrote:
Hi all,
Please review a test bug fix
TEST : *closed/javax/swing/JMenu/4213634/bug4213634.java *
BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8017187*
Please*move the test from closed repo tom open repo*.
The webrev
is:http://cr.openjdk.java.net/~sgupta/8017187/webrev.00/ add
to open repo
http://cr.openjdk.java.net/~kshefov/8017187/webrev.diff/ -
diff with previous version of the closed test.
--
Thanks and Regards,
Nadeesh TV
--
Best regards, Sergey.
