Hello All, I need one more review for this fix. Can someone please review it. Webrev : http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/
Regards, Rajeev Chamyal -----Original Message----- From: Alexander Scherbatiy Sent: Tuesday, September 08, 2015 2:27 PM To: Rajeev Chamyal Cc: Philip Race; Alexander Zvegintsev; swing-dev@openjdk.java.net Subject: Re: <Swing Dev> Request for review fo bug JDK-8032568 Test javax/swing/JInternalFrame/8020708/bug8020708.java fails on Windows virtual hosts The fix looks good to me. Thanks, Alexandr. On 9/8/2015 11:25 AM, Rajeev Chamyal wrote: > Hello All, > > Please review the below webrev. > > http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.02/ > > > Regards, > Rajeev Chamyal > > -----Original Message----- > From: Alexander Scherbatiy > Sent: Monday, September 07, 2015 6:21 PM > To: Rajeev Chamyal > Cc: Philip Race; Alexander Zvegintsev; swing-dev@openjdk.java.net > Subject: Re: <Swing Dev> Request for review fo bug JDK-8032568 Test > javax/swing/JInternalFrame/8020708/bug8020708.java fails on Windows > virtual hosts > > On 9/7/2015 9:34 AM, Rajeev Chamyal wrote: >> Hello All, >> >> Please review the following webrev. I have updated the fix as per review >> comments. >> >> http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.01/ > - "String textAndMnemonic" variable is now just a mnemonic. > - Integer.parseInt(str) already throws NumberFormatException for null > or empty string > - it is not necessary to assign a default value to the keyCode in the > catch block because it already has it. > > Thanks, > Alexandr. > >> Regards, >> Rajeev Chamyal >> >> -----Original Message----- >> From: Phil Race >> Sent: Thursday, September 03, 2015 11:26 PM >> To: Rajeev Chamyal >> Cc: Alexander Scherbatiy; Alexander Zvegintsev; >> swing-dev@openjdk.java.net >> Subject: Re: <Swing Dev> Request for review fo bug JDK-8032568 Test >> javax/swing/JInternalFrame/8020708/bug8020708.java fails on Windows >> virtual hosts >> >> Could you instead use >> https://docs.oracle.com/javase/8/docs/api/javax/swing/AbstractButton. >> h >> tml#getMnemonic-- >> ? >> >> Of course you need to get the button itself first rather than the string. >> >> -phil. >> >> On 09/03/2015 08:39 AM, Rajeev Chamyal wrote: >>> Hello All, >>> >>> I need one more review for this fix. Can someone please review it. >>> >>> Webrev : >>> http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.00/ >>> >>> Regards, >>> Rajeev Chamyal >>> >>> -----Original Message----- >>> From: Sergey Bylokhov >>> Sent: Thursday, September 03, 2015 9:05 PM >>> To: Rajeev Chamyal; Alexander Scherbatiy; Alexander Zvegintsev; >>> swing-dev@openjdk.java.net >>> Subject: Re: Request for review fo bug JDK-8032568 Test >>> javax/swing/JInternalFrame/8020708/bug8020708.java fails on Windows >>> virtual hosts >>> >>> The fix looks good. >>> >>> On 03.09.15 9:15, Rajeev Chamyal wrote: >>>> Hi, >>>> >>>> Please review the following fix for jdk9: >>>> >>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8032568 >>>> >>>> Webrev : >>>> http://cr.openjdk.java.net/~psadhukhan/rajeev/8032568/webrev.00/ >>>> >>>> Translation team has changed the JInternalFrame close mnemonic character >>>> from C to different character for different languages. >>>> >>>> For example in German close mnemonic is now S and for French its now F. To >>>> fix the issue we are now finding the correct mnemonic character and >>>> passing it to robo. >>>> >>>> Regards, >>>> >>>> Rajeev Chamyal >>>>
