The fix looks good to me. Regards, Rajeev Chamyal
-----Original Message----- From: Alexander Scherbatiy Sent: 17 November 2015 15:34 To: Avik Niyogi Cc: Rajeev Chamyal; [email protected] Subject: Re: Review request for 7124218: Space should select cell in the JTable The fix looks good to me. Thanks, Alexandr. On 11/16/2015 9:48 AM, Avik Niyogi wrote: > Hi All, > > The bug fix has been updated as per the comments. > http://cr.openjdk.java.net/~rchamyal/avik/7124218/webrev.01/ > <http://cr.openjdk.java.net/%7Erchamyal/avik/7124218/webrev.01/> > > > With Regards, > Avik Niyogi > >> On 11-Nov-2015, at 8:20 pm, Alexander Scherbatiy >> <[email protected] >> <mailto:[email protected]>> wrote: >> >> >> - May be isMac() method can only check L&F because a L&F which >> contains Mac description usually implies that it is L&F designed for >> Mac OS X >> - isMac(osName, lookAndFeel) check is used to do different actions >> but the only essential difference is in the provided key code. >> it can be changed to keyTap(isMac(...) ? KeyEvent.VK_ENTER : >> KeyEvent.SPACE) >> - The exception handling in the tryLookAndFeel() method is skipped. >> What should be the test behavior in case if it is not possible to >> set a L&F? >> - runTestCase() method should access JTable methods on EDT. >> >> Thanks, >> Alexandr. >> >> On 11/3/2015 12:20 PM, Avik Niyogi wrote: >>> Hi All, >>> >>> Kindly review the fix for JDK9. >>> *Bug*: https://bugs.openjdk.java.net/browse/JDK-7124218 >>> >>> *Webrev*: >>> http://cr.openjdk.java.net/~rchamyal/avik/7124218/webrev.00/ >>> <http://cr.openjdk.java.net/%7Erchamyal/avik/7124218/webrev.00/> >>> <http://cr.openjdk.java.net/%7Erchamyal/avik/7124218/webrev.00/> >>> >>> *Issue*: "Space should select cell in the JTable" is being expected >>> for Look and Feels (and OS) where key-bindings are different. >>> >>> *Cause*: Keybindings expected in the test case are not taking native >>> key-bindings into account. >>> >>> *Fix*: Recreated test case with appropriate cases for all required >>> OS to account for supported native, non-native and cross-platform >>> Look and Feels. >>> >>> With Regards, >>> Avik Niyogi >> >
