Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception

[Sergey Bylokhov]

Hi, Rajeev.
A few notes:
- The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse 
the new "c" variable.
- Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems 
that it is not used after the null check.

On 30/12/15 10:30, Rajeev Chamyal wrote:
Hello All,

I need one more review for this webrev.

http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/
<http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/>

Regards,

Rajeev Chamyal

*From:*Alexander Scherbatiy
*Sent:* 23 December 2015 19:44
*To:* Rajeev Chamyal
*Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net
*Subject:* Re: Review request for JDK-8145896 JInternalFrame setMaximum
before adding to desktop throws null pointer exception


   The fix looks good to me.

   Thanks,
   Alexandr.

On 12/21/2015 3:09 PM, Rajeev Chamyal wrote:

    Hello All,

    Please review the following fix for Jdk9:

    Bug: https://bugs.openjdk.java.net/browse/JDK-8145896

    Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/
    <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/>

    Issue: JInternalFrame setMaximum before adding to desktop throws
    null pointer exception

    Cause: Null checks for parent and Desktop pane are missing

    Fix: Added null checks for parent and desktop pane.

    Verified the fix on windows,Ubuntu and Mac with all supported LAF.

    Regards,

    Rajeev Chamyal



--
Best regards, Sergey.