Looks good to me. Regards, Rajeev Chamyal
-----Original Message----- From: Semyon Sadetsky Sent: 24 March 2016 11:45 To: Prem Balakrishnan; Sergey Bylokhov; Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Review Request for 6439354 : Win L&F: TitledBorder colors are not from desktop Looks good. --Semyon On 3/22/2016 11:56 AM, Prem Balakrishnan wrote: > Hi Sergey, > > Updated test as per the review comments. > > Webrev: http://cr.openjdk.java.net/~arapte/prem/6439354/webrev.01/ > > Regards, > Prem > > > -----Original Message----- > From: Sergey Bylokhov > Sent: Monday, March 21, 2016 7:31 PM > To: Prem Balakrishnan; Semyon Sadetsky; Rajeev Chamyal; Alexander > Scherbatiy; swing-dev@openjdk.java.net > Subject: Re: Review Request for 6439354 : Win L&F: TitledBorder colors > are not from desktop > > Hi, Prem. > In the test the Swing components accessed on non-EDT thread. Probably the > test can be simplified further? > > On 21.03.16 11:20, Prem Balakrishnan wrote: >> Hi*,* >> >> Please review fix for JDK 9, >> >> *Bug: *https://bugs.openjdk.java.net/browse/JDK-6439354 ** >> >> *Webrev: *http://cr.openjdk.java.net/~arapte/prem/6439354/webrev.00/ >> >> *Issue:* >> >> Win L&F: TitledBorder colors are not from desktop >> >> *Cause:* >> >> "TitledBorder.border" is set to EtchedBorder with default >> highlight/shadow colors. >> >> *Fix:* >> >> "TitledBorder.border" is set to EtchedBorder with Desktop >> highlight/shadow colors. >> >> ** >> >> *Test: *Manual Test (since windows theme to be set)** >> >> ** >> >> Regards, >> Prem >> > > -- > Best regards, Sergey.
