On 22/03/16 10:13, Ahmad Ahmad wrote:
Hello,
Please review fix for JDK9 test bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8143021
Webrev: http://cr.openjdk.java.net/~srastogi/shaik/webrev.01/
<http://cr.openjdk.java.net/%7Esrastogi/shaik/webrev.01/>
115 if (c instanceof JTabbedPane) {
116 JTabbedPane dummy = (JTabbedPane) c;
117 dummy.removeTabAt(0);
118 }
It is better to find the HSV tab and set it selected rather to remove
the first tab in this case.
The spinner search is also better to do on EDT.
Issue:
java.lang.Error: found visible window: frame0
at Test6541987.main(Test6541987.java:64)
Cause:
Test is failing in Ubuntu OS as intermittently due to frame is visible
but ideally all windows should be closed, introduced delay to solve
the issue.
Fix:
Beside reported issue in the bug, When I tested on Mac OS, Test never
passed due to ALT + H + 4 TABs still keep the focus in the slider and
not on spinner
Alt+H should select HSV tab but there is the known issue that
mnemonics do not work for tabs in JTabbedPane on Mac OS X:
8064922 [macosx] Test javax/swing/JTabbedPane/4624207/bug4624207.java
fails
https://bugs.openjdk.java.net/browse/JDK-8064922
Thanks,
Alexandr.
but the actual test is all about ensuring JColorChooser disappears
when pressing esc, keeping the focus on the spinner.
Test verified in Mac OS, Windows, OEL and Ubuntu.
Thanks & Regards
Shaik Ahmad
