Hi Prasanta,
Sorry , It was my mistake, initially I didn't notice that, I was catching exception as well as declared it to be thrown. Updated Webrev as per review comments. http://cr.openjdk.java.net/~arapte/prem/8153056/webrev.02/ Regards, Prem From: Prem Balakrishnan Sent: Monday, April 18, 2016 11:03 AM To: Prasanta Sadhukhan; Alexander Scherbatiy; Sergey Bylokhov; Semyon Sadetsky; Rajeev Chamyal; [email protected] Subject: Re: <Swing Dev> Review Request JDK-8153056 : 8152647(duplicate of 6439354) Manual Test always passes Hi Prasanta, 1. This test was initially written in the year 2016 (by me), later found the issue with the test file and correcting it. By mistake added the 1999 to the copyright, hence removed it. 2. try/catch block is Not redundant , await() method throws InterruptedException, which must be caught or declared to be thrown. public void await() throws HYPERLINK "https://docs.oracle.com/javase/7/docs/api/java/lang/InterruptedException.html"InterruptedException Regards, Prem From: prasanta sadhukhan Sent: Friday, April 15, 2016 8:37 PM To: Prem Balakrishnan; Alexander Scherbatiy; Sergey Bylokhov; Semyon Sadetsky; Rajeev Chamyal; HYPERLINK "mailto:[email protected]"[email protected] Subject: Re: <Swing Dev> Review Request JDK-8153056 : 8152647(duplicate of 6439354) Manual Test always passes Hi Prem, Why did you remove 1999 from the copyright? I guess that's the initial year when this test was written. I guess we need to keep it and make like 1999,2016. I guess also this try/catch block is redundant try { 56 latch.await(); 57 } catch (InterruptedException ie) { 58 throw ie; 59 } Regards Prasanta On 4/15/2016 1:52 PM, Prem Balakrishnan wrote: Hi Alexander, Thank you for the review. Updated test with CountDownLatch. http://cr.openjdk.java.net/~arapte/prem/8153056/webrev.01/ Regards, Prem From: Alexander Scherbatiy Sent: Thursday, March 31, 2016 11:32 PM To: Prem Balakrishnan; Sergey Bylokhov; Semyon Sadetsky; Rajeev Chamyal; HYPERLINK "mailto:[email protected]"[email protected] Subject: Re: Review Request JDK-8153056 : 8152647(duplicate of 6439354) Manual Test always passes On 31/03/16 14:59, Prem Balakrishnan wrote: Hi Alexander, Thankyou for the review. I agree with what you said ,jtreg does not wait for new created JFrame. Executed test on : Jtreg version: 4.2.0 and 4.1 , facing same issue, even without user/tester validating the output test status shows passed. It looks like jtreg does not wait for UI closing for manual main tests. May be it is better to use CountDownLatch in this case? It least there will not be necessary to distinguish InterruptedException generated by program of by other reasons. Thanks, Alexandr. Hence test enhanced to overcome the above scenario. Regards, Prem From: Alexander Scherbatiy Sent: Wednesday, March 30, 2016 10:40 PM To: Prem Balakrishnan; Sergey Bylokhov; Semyon Sadetsky; Rajeev Chamyal; HYPERLINK "mailto:[email protected]"[email protected] Subject: Re: Review Request JDK-8153056 : 8152647(duplicate of 6439354) Manual Test always passes On 30/03/16 16:08, Prem Balakrishnan wrote: Hi, Please review fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8153056 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Earapte/prem/8153056/webrev.00/"http://cr.openjdk.java.net/~arapte/prem/8153056/webrev.00/ Issue: 8152647(duplicate of 6439354) Manual Test always passes Fix: Enhanced Test(with Pass, Fail and Timeout) It does not look as issue in the test but rather as jtreg does not wait for new created JFrame. Could you run the test without the fix with previous version of jtreg? Is the JFrame is shown in this case? Thanks, Alexandr. Regards, Prem
