Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

[Semyon Sadetsky]

Hi Rajeev,

As I understand you have reverted 8037575 fix.

How the 8037575 will be addressed now?

--Semyon

On 7/18/2016 9:03 AM, Rajeev Chamyal wrote:

Hello Alexandr,

Please review the updated webrev.

http://cr.openjdk.java.net/~rchamyal/8158918/webrev.01/ <http://cr.openjdk.java.net/%7Erchamyal/8158918/webrev.01/>

Regards,

Rajeev Chamyal

*From:*Alexandr Scherbatiy
*Sent:* 14 July 2016 20:54
*To:* Rajeev Chamyal; Semyon Sadetsky; swing-dev@openjdk.java.net

*Subject:* Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

On 7/14/2016 1:18 PM, Rajeev Chamyal wrote:

    Hello All,

    Please review the following webrev.

    Bug: https://bugs.openjdk.java.net/browse/JDK-8158918

    Webrev: http://cr.openjdk.java.net/~rchamyal/8158918/webrev.00/
    <http://cr.openjdk.java.net/%7Erchamyal/8158918/webrev.00/>

    Issue: Frame setExtendedState = 1 on a maximized frame is not working.

    Cause: Issue is due to ::ShowWindow API call added as part of fix
    for JDK-8037575 <https://bugs.openjdk.java.net/browse/JDK-8037575>

    Fix: Removed the ShowWindow call a sepate bug will be created for
    JDK-8037575 <https://bugs.openjdk.java.net/browse/JDK-8037575>

   40 if (frame.getExtendedState() != 1) {
   It is better to use the named frame state constant instead of just 1.

  Thanks,
  Alexandr.

    Regards,

    Rajeev Chamyal