On 25.10.16 21:19, Phil Race wrote:

Hi,

OK with the change below and the rest of the explanation this is
probably good to go ..

What is the reason to remove(instead of append it) old code which describe what the method do, for example:
-     * Sets the row height, this is forwarded to the treeState.
+     * Called when the {@code rowHeight} property is changed in
+     * the drawn tree component.

If we add a notions that some of the methods are called as a result of property changes, then probably other methods should be updated as well? For example setSelectionModel is called when "selectionModel" is changed.

Small typo after the "{@code editable}":
-     * @param newValue the new value
+     * @param newValue the new value of the {@code editable}> property

On 07/18/2016 10:37 AM, Semyon Sadetsky wrote:

O.k. I would use "displayed" because it simply proxies
tree.isRootVisible() which has "displayed" in its specs.

  Returns whether the root node of the drawn tree component *should be
displayed*.



--
Best regards, Sergey.

Reply via email to