Looks good to me.
Regards,
Rajeev Chamyal
-----Original Message-----
From: Prasanta Sadhukhan
Sent: 26 October 2016 12:54
To: Rajeev Chamyal; Alexandr Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [9] RFR JDK-8168657: [PIT] Still, on Windows test
always fails:
java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
Please review this.
diff -r aae3690e53e3
test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
---
a/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
Thu Oct 20 14:21:46 2016 +0300
+++
b/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
Wed Oct 26 12:53:21 2016 +0530
@@ -44,9 +44,11 @@
import javax.imageio.ImageIO;
/**
- * @test @bug 8145174 8151787
+ * @test
+ * @bug 8145174 8151787 8168657
* @summary HiDPI splash screen support on Linux
* @modules java.desktop/sun.java2d
+ * @requires (os.family == "linux")
* @run main UnixMultiResolutionSplashTest
*/
public class UnixMultiResolutionSplashTest {
Regards
Prasanta
On 10/26/2016 12:49 PM, Prasanta Sadhukhan wrote:
> Hi All,
>
> Please review a simple fix for splasscreen testissue where we need to
> restrict this test from running on linux as this test uses linux
> enviroment variable GDK_SCALE so restricting to run only on linux.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8168657
>
> diff -r aae3690e53e3
> test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolut
> ionSplashTest.java
> ---
> a/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResol
> utionSplashTest.java
> Thu Oct 20 14:21:46 2016 +0300
> +++
> b/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResol
> utionSplashTest.java
> Wed Oct 26 12:46:56 2016 +0530
> @@ -47,6 +47,7 @@
> * @test @bug 8145174 8151787
> * @summary HiDPI splash screen support on Linux
> * @modules java.desktop/sun.java2d
> + * @requires (os.family == "linux")
> * @run main UnixMultiResolutionSplashTest
> */
> public class UnixMultiResolutionSplashTest {
>
>
> Regards
> Prasanta
