JPRT job ran OK. Just need +1s from Phil/Mandy for the comment change shown below.
On 11/1/16 9:56 AM, Pete Brunet wrote: > Mandy and Phil, I thought it would be helpful to add this to the comment > in AccesssBridgeCalls.h: > > * > * Also note that the API is used in the jaccessinspector and > jaccesswalker tools. > * The source for those tools is available in the OpenJDK repository at > these links: > * > * > http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/src/jdk.accessibility/windows/native/jaccessinspector/jaccessinspector.cpp > * > http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/src/jdk.accessibility/windows/native/jaccesswalker/jaccesswalker.cpp > * > > http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.10/ > > I'll start the JPRT job today and then once I get your approval for that > comment I will push this into 9. > > Pete > > On 11/1/16 4:27 AM, Erik Joelsson wrote: >> Looks good. >> >> /Erik >> >> On 2016-10-31 15:36, Pete Brunet wrote: >>> On 10/28/16 8:14 PM, Mandy Chung wrote: >>>>> On Oct 28, 2016, at 1:59 PM, Philip Race <[email protected]> >>>>> wrote: >>>>> >>>>> If it is not in the image then there is no point in the file existing. >>>>> Maybe this could just be a comment at the top of the include file. >>>>> >>>> This works for me. >>> Updated: >>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.09/ >>>> Mandy >>>> >>>>> -phil. >>>>> >>>>> On 10/28/16, 12:42 PM, Mandy Chung wrote: >>>>>>> On Oct 28, 2016, at 11:32 AM, Pete >>>>>>> Brunet<[email protected]> wrote: >>>>>>> >>>>>>> Hi Mandy, That simplifies things. The new patch is at: >>>>>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.08/ >>>>>> Looks better. >>>>>> >>>>>> I only notice now that the readme.html is in the include >>>>>> directory. That should be in the documentation as you proposed >>>>>> earlier. I don’t think it should be copied to the image. >>>>>> >>>>>> Mandy >>>>>>
