Re: [9] Review request for 8168992 Add floating point implementation for new BasicGraphicsUtils text related methods use floating point API

Tue, 01 Nov 2016 23:59:32 -0700 

+1

--Semyon


On 11/1/2016 5:13 PM, Sergey Bylokhov wrote:

Looks fine.

On 01.11.16 16:47, Alexandr Scherbatiy wrote:


Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8168992
  webrev: http://cr.openjdk.java.net/~alexsch/8168992/webrev.00

  The fix JDK-8132119 added stubs for the following methods:
  BasicGraphicsUtils.drawString(JComponent c, Graphics2D g, String
string, float x, float y)
  BasicGraphicsUtils.drawStringUnderlineCharAt(JComponent c, Graphics2D
g, String string, int underlinedIndex, float x, float y)
  BasicGraphicsUtils.getStringWidth(JComponent c, FontMetrics fm, String
string)

  The current fix adds implementation which uses floating point API for
these methods.

  The fix also updated the implementation to use floating point API for
the method:
    Utilities.drawTabbedText(Segment s, float x, float y, Graphics2D g,
TabExpander e, int startOffset)

 Thanks,
 Alexandr.

Reply via email to