On 15.11.16 20:18, Alexandr Scherbatiy wrote:
On 11/15/2016 5:08 PM, Sergey Bylokhov wrote:
Should "@SuppressWarnings("deprecation")" be removed from this method?
Why the test is linux and windows specific?
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8169719/webrev.01/
- "@SuppressWarnings("deprecation")"is removed
The test is not suitable for Mac OS X because chars advances on Mac OS
X have integer values.
There is Solaris also, but as far as I understand the fractional chars
text is a system/platform specifics and it is not necessary be so on
some windows/linux? or it is always fractional?
Thanks,
Alexandr.
On 15.11.16 16:49, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8169719
webrev: http://cr.openjdk.java.net/~alexsch/8169719/webrev.00
WrappedPlainView.modelToView() method is updated to use
Utilities.getTabbedTextWidth() which returns floating point text width.
Thanks,
Alexandr.
--
Best regards, Sergey.