Hi All,

 

Please review the test bug fix for JDK-8169954 : JFileChooser/8021253: 
java.lang.RuntimeException: Default button is not pressed.

 

Issue:

The Test under  8021253 is opening up a filechooser iconified, causing a 
failure to hit Enter key on the filechooser. Test failure is intermittent and 
more pronounced when run along with the entire javax/swing suite.

 

Fix:

This is occurring due to synchronization issues in the previous test 7199708. 
The test for bug 7199708 checks if the filechooser can load up a large number 
of files without a crash. In doing so it also tries to sort the columns of the 
filechooser via Robot mouse move and click actions. 
Commenting out these robot actions ensured that the next test 8021253 was 
passing indicating that this was a problem of with synchronization of the 
filechooser UI sorting and disposal of filechooser and that root cause was that 
these were not synchronized properly. Hence fixed the code flow using the 
regtesthelpers classes, to ensure that this is working correctly now.

Also ensured the filechooser of test 8021253 is not opened iconified and has 
focus. 

 

Testing:

Tested the potential fix on winx64, linux  with JDK8, 9 several times with 
running tests individually clubbed with the previous test and the entire suite 
(i.e javax/swing) put to ensure that the issue is not repeated.

 

Bug Id:

https://bugs.openjdk.java.net/browse/JDK-8169954

 

WebRev Request:

http://cr.openjdk.java.net/~akolarkunnu/8169954/webrev.00/

 

 

Regards,

Srinivas M

Reply via email to