Looks good to me. Only thing is in my opinion, 5 min timeout is too
much. I guess 1 minutes should be sufficient. No need for webrev if you
consider to make that change.
Regards
Prasanta
On 6/12/2017 7:51 PM, Sreeprakash Sreedharan wrote:
Thanks for the inputs, Prasanta.
I have incorporated the changes mentioned.
Updated Webrev : http://cr.openjdk.java.net/~rpatil/8181782/webrev.01
Regards,
Sreeprakash
-----Original Message-----
From: Prasanta Sadhukhan
Sent: Monday, June 12, 2017 2:55 PM
To: Sreeprakash Sreedharan <sreeprakas...@oracle.com>;
swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [10] RFR: JDK-8181782:[TESTBUG] [Macosx]
JTextAreaEmojiTest is not executed
It seems the test is waiting infinitely instead of having a timeout. I amnot
sure of jtreg timeout but it's better to rely on test's own timeout, so
await(timeout) is a better call .
Also, please add @key headful tag to the test.
Regards
Prasanta
On 6/9/2017 1:38 AM, Sreeprakash Sreedharan wrote:
Hi All,
Kindly review the fix for JDK10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8181782
Webrev: http://cr.openjdk.java.net/~rpatil/8181782/webrev.00
Issue: JTREG was not executing the manual test JTextAreaEmojiTest and was
always giving a passed result.
Fix: Made sure that main function waits for pass/fail events using a
countdown latch and also added manual to the run tag
Regards,
Sreeprakash
