+1

On 26.07.2017 1:24, Vikrant Agarwal wrote:
Gentle Reminder, need 1 more review.

Best Regards,

Vikrant

*From:*Alexandre (Shura) Iline
*Sent:* Thursday, July 13, 2017 8:49 PM
*To:* Vikrant Agarwal
*Cc:* [email protected]; Sergey Bylokhov; Semyon Sadetsky; Srinivas Mandalika; Muneer Kolarkunnu *Subject:* Re: <Swing Dev> [10] RFR JDK-8184325: Add subcomponents accessor methods to JColorChooserOperator

Looks good.

Thank you.

Shura

    On Jul 13, 2017, at 1:53 AM, Vikrant Agarwal
    <[email protected] <mailto:[email protected]>>
    wrote:

    Hi All,

    Please review the following fix:

    Bug :JDK-8184325 <https://bugs.openjdk.java.net/browse/JDK-8184325>

    JDK 10 Webrev: http://cr.openjdk.java.net/~vagarwal/8184325/webrev.00/

    Summary:

    This is to  add the following subcomponents accessor methods to
    JColorChooserOperator in Jemmy:

    public JSpinnerOperator getHueSpinnerOperator()
    public JSpinnerOperator getSaturationSpinnerOperator()
    public JSpinnerOperator getValueSpinnerOperator()
    public JSpinnerOperator getTransparencySpinnerOperator()
    public JSpinnerOperator getLightnessSpinnerOperator()
    public JSpinnerOperator getRedSpinnerOperator()
    public JSpinnerOperator getGreenSpinnerOperator()
    public JSpinnerOperator getBlueSpinnerOperator()
    public JSpinnerOperator getAlphaSpinnerOperator()
    public JSpinnerOperator getCyanSpinnerOperator()
    public JSpinnerOperator getMagentaSpinnerOperator()
    public JSpinnerOperator getYellowSpinnerOperator()
    public JSpinnerOperator getBlackSpinnerOperator()
    public JTextFieldOperator getColorCodeTextFieldOperator()


    Similar methods for respective sliders.

    We are first getting the selected tab index through
    getSelectedTabIndex(..) and then using this to get the respective
    operator.

    Best Regards,

    Vikrant



--
Best regards, Sergey.

Reply via email to