Hi Sergey, Please find the new Webrev to fix the comments: http://cr.openjdk.java.net/~pkbalakr/shashi/8178106/webrev.03/
Thanks and regards, Shashi -----Original Message----- From: Sergey Bylokhov Sent: Tuesday, August 1, 2017 2:05 AM To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>; Prasanta Sadhukhan <prasanta.sadhuk...@oracle.com> Cc: swing-dev@openjdk.java.net Subject: Re: <Swing Dev> [10] JDK-8178106: There is no error message pop up when clicking 'create folder' button On 27.07.2017 11:10, Shashidhara Veerabhadraiah wrote: > The test asks to create a folder for the test and the same shall be requested > to delete so that the system gets back to the same state as before the test. > Is not that is good? Yes it is fine to request the user to change permissions back at the end of the test, otherwise "Newly created folder may now be deleted". > > shashi > > -----Original Message----- > From: Sergey Bylokhov > Sent: Thursday, July 27, 2017 11:36 PM > To: Shashidhara Veerabhadraiah > < HYPERLINK "mailto:shashidhara.veerabhadra...@oracle.com"; > shashidhara.veerabhadra...@oracle.com>; Prasanta Sadhukhan > < HYPERLINK "mailto:prasanta.sadhuk...@oracle.com"; > prasanta.sadhuk...@oracle.com> > Cc: HYPERLINK "mailto:swing-dev@openjdk.java.net"; swing-dev@openjdk.java.net > Subject: Re: <Swing Dev> [10] JDK-8178106: There is no error message > pop up when clicking 'create folder' button > > I guess it will be better to notify the user that the permissions should be > restored. > > On 26.07.2017 23:27, Shashidhara Veerabhadraiah wrote: >> Here is the new Webrev with the requested changes: >> >> http://cr.openjdk.java.net/~pkbalakr/shashi/8178106/webrev.02/ >> >> Thanks and regards, >> >> Shashi >> >> *From:*Sergey Bylokhov >> *Sent:* Wednesday, July 26, 2017 10:17 PM >> *To:* Prasanta Sadhukhan < HYPERLINK "mailto:prasanta.sadhuk...@oracle.com"; >> prasanta.sadhuk...@oracle.com> >> *Cc:* HYPERLINK "mailto:swing-dev@openjdk.java.net"; >> swing-dev@openjdk.java.net; Shashidhara Veerabhadraiah >> < HYPERLINK "mailto:shashidhara.veerabhadra...@oracle.com"; >> shashidhara.veerabhadra...@oracle.com> >> *Subject:* Re: <Swing Dev> [10] JDK-8178106: There is no error >> message pop up when clicking 'create folder' button >> >> I guess the user will need to set permissions back at the end of the >> test? Otherwise jtreg will not be able to delete it(if the folder >> will be created in the results). >> >> ----- HYPERLINK "mailto:prasanta.sadhuk...@oracle.com"; >> prasanta.sadhuk...@oracle.com >> <mailto:prasanta.sadhuk...@oracle.com> wrote: >> > >> >> looks fine. >> > >> >> Regards >> > Prasanta >> > >> >> > On 7/26/2017 3:05 PM, Shashidhara Veerabhadraiah wrote: >> > >> >> > >> >> Hi, Please find the updated Webrev @ >> >> http://cr.openjdk.java.net/~pkbalakr/shashi/8178106/webrev.01/ >> >> <http://cr.openjdk.java.net/%7Epkbalakr/shashi/8178106/webrev.01/> >> >> Thanks and regards, >> >> Shashi >> >> > >> >> *From:*Prasanta Sadhukhan >> > *Sent:* Wednesday, July 26, 2017 1:52 PM >> > *To:* Shashidhara Veerabhadraiah >> < HYPERLINK "mailto:shashidhara.veerabhadra...@oracle.com"; >> shashidhara.veerabhadra...@oracle.com> >> <mailto:shashidhara.veerabhadra...@oracle.com>; >> HYPERLINK "mailto:swing-dev@openjdk.java.net"; >> swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> >> > *Subject:* Re: <Swing Dev> [10] JDK-8178106: There is no error >> message pop up when clicking 'create folder' button >> >> ok. Probably, you can make the test instructions more clear citing >> "by changing security permission through Security tab under >> Folder->properties menu to deny write permissions to the newly >> created folder.." >> >> Regards >> > Prasanta >> >> On 7/26/2017 1:47 PM, Shashidhara Veerabhadraiah wrote: >> >> Yes. Now this fix has been tested on window 7 and windows 8.1 as >> well. The way to set the folder properties is same and the >> expected error message pops up if we tried to create a new >> folder under the read-only directory. >> >> Thanks and regards, >> >> Shashi >> >> > >> >> *From:*Prasanta Sadhukhan >> > *Sent:* Monday, July 24, 2017 4:06 PM >> > *To:* Shashidhara Veerabhadraiah >> < HYPERLINK "mailto:shashidhara.veerabhadra...@oracle.com"; >> shashidhara.veerabhadra...@oracle.com> >> <mailto:shashidhara.veerabhadra...@oracle.com>; >> HYPERLINK "mailto:swing-dev@openjdk.java.net"; >> swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> >> > *Subject:* Re: <Swing Dev> [10] JDK-8178106: There is no error >> message pop up when clicking 'create folder' button >> >> On 7/24/2017 4:04 PM, Prasanta Sadhukhan wrote: >> >> ok. Then what about windows 7? Did you test there as well? >> >> and windows 8.1 since the affected OS is 8.1. >> > >> > >> > >> >> Regards >> > Prasanta >> >> On 7/24/2017 3:56 PM, Shashidhara Veerabhadraiah wrote: >> >> Hi Prasanta, I have verified this on Windows 10 itself. >> Below is the output of the system info where it was tested: >> >> >> >> OS Name:Microsoft Windows 10 Pro >> >> OS Version:10.0.14393 N/A Build 14393 >> >> OS Manufacturer:Microsoft Corporation >> >> OS Configuration:Member Workstation >> >> OS Build Type:Multiprocessor Free >> >> BIOS Version:LENOVO R06ET47W (1.21 ), >> 11/30/2016 >> >> >> >> Thanks and regards, >> > Shashi >> >> >> >> > >> >> *From:*Prasanta Sadhukhan >> > *Sent:* Monday, July 24, 2017 3:43 PM >> > *To:* Shashidhara Veerabhadraiah >> < HYPERLINK "mailto:shashidhara.veerabhadra...@oracle.com"; >> shashidhara.veerabhadra...@oracle.com> >> <mailto:shashidhara.veerabhadra...@oracle.com>; >> HYPERLINK "mailto:swing-dev@openjdk.java.net"; >> swing-dev@openjdk.java.net >> <mailto:swing-dev@openjdk.java.net> >> > *Cc:* Philip Race < HYPERLINK >> "mailto:philip.r...@oracle.com"; philip.r...@oracle.com> >> <mailto:philip.r...@oracle.com>; Sergey Bylokhov >> < HYPERLINK "mailto:sergey.bylok...@oracle.com"; >> sergey.bylok...@oracle.com> >> <mailto:sergey.bylok...@oracle.com> >> > *Subject:* Re: <Swing Dev> [10] JDK-8178106: There is no >> error message pop up when clicking 'create folder' >> button >> >> >> >> Hi Shashi, >> >> Which windows version you tested? >> > Could you also verify with windows 10 (if not already >> tested) if this way of making folder read-only is valid >> or doable (if not, then the instructions may need to be >> changed)? >> > >> > Regards >> > Prasanta >> >> On 7/24/2017 3:28 PM, Shashidhara Veerabhadraiah wrote: >> >> Hi All, >> >> Please review a fix for the JDK-8178106 where there >> was no error message being popped up when creating a >> new folder. >> >> >> >> Issue: When creating a new folder under a read-only >> set folder causes no pop up with respect to the error. >> >> >> >> Resolution: The test instruction does not elaborate >> on how to make the folder read-only and hence the >> failure. Windows offers to set this via the security >> option of the folder properties and deny the write >> operation for the folder apart from the read-only >> attribute being set while creating the folder >> itself. The test instructions are modified to >> indicate a way to set the read-only attribute of the >> folder. >> >> >> >> >> >> Test output: After setting folder permission >> correctly, the below output being seen as expected. >> >> >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8178106 >> >> Webrev: >> >> http://cr.openjdk.java.net/~aghaisas/shashi/8178106/webrev.00/ >> >> <http://cr.openjdk.java.net/%7Eaghaisas/shashi/8178106/webrev.00/> >> >> >> >> Thanks and regards, >> >> Shashi >> >> >> >> >>> >> > > > -- > Best regards, Sergey. > -- Best regards, Sergey.
