looks good to me.
Regards
Prasanta
On 30-Oct-18 4:30 PM, Pankaj Bansal wrote:
Hi All, Please review test fix for the below bug:
Bug: https://bugs.openjdk.java.net/browse/JDK-8212903
webrev: http://cr.openjdk.java.net/~pbansal/8212903/webrev.00/
<http://cr.openjdk.java.net/%7Epbansal/8212903/webrev.00/>
Issue:
The tests DemandGTK2.sh and DemandGTK3.sh verify whether a particular
version of gtk library is being used or not while using the
GTKLookAndFeel. They use “strace” to find which gtk library has been
opened by tracing the system command used to load the libraries.
Currently, these tests are tracing the “open” which is used to open
the library on Ubuntu 16.04 LTS.
These tests are failing on Ubuntu 18.04 LTS as the “openat” command
is used to open the libs instead of “open”. So the “openat” should be
traced on 18.04 LTS.
Fix:
Made changes to the tests to trace both “open” and “openat”. The tests
now pass on both Ubuntu 16.04 LTS and 18.04 LTS.
Regards,
Pankaj Bansal
