On 15-Nov-18 12:36 AM, Sergey Bylokhov wrote:
Hi, Prasanta
Could you please clarify how this "ClassCastException" is related to the
"Wrong focus owner" which is reported in the bug?
It is not related. It is there to cater to the problem seen in
JDK-8198334: which btw I am not able to reproduce in mach5. For wrong
focus owner problem, which I am not seeing in locally and only seen in
mach5, I have added keyword @headful to the test in
http://cr.openjdk.java.net/~psadhukhan/8213514/webrev/ to mitigate
problem of this headful test being run on headless environment.
Regards
Prasanta
Note that HeadlessGraphicsEnvironment does not implement
DisplayChangedListener
so the additional check for HeadlessGraphicsEnvironment is not necessary.
On 13/11/2018 02:32, Prasanta Sadhukhan wrote:
Modified webrev to prevent ClassCastException which can happen in
headless environment where
GraphicsEnvironment.getLocalGraphicsEnvironment() can return
HeadlessGraphicsEnvironment.
http://cr.openjdk.java.net/~psadhukhan/8213514/webrev.1/
Regards
Prasanta
On 09-Nov-18 9:22 AM, Prasanta Sadhukhan wrote:
On 09-Nov-18 2:22 AM, Sergey Bylokhov wrote:
On 08/11/2018 01:11, Prasanta Sadhukhan wrote:
Hi Sergey,
I am not getting ClassCastException when I run
com/sun/java/swing/plaf/windows/Test8173145 on mach5, rather I get
the below mentioned exception.
I guess the below problem is expected as we are trying to run
headful test on headless environment.
Take a look to the test, it ignores all exceptions(I guess
including HeadlessException)
which are occurred during creation of the frame,
and the "test()" starts only if the frame and all components were
created successfully.
If it ignores all exception, then how did you get the log where it
shows it received HeadlessException and ClassCastException for this
test?
Regards
Prasanta
java.lang.RuntimeException: Wrong focus owner
jib > at Test8173145.test(Test8173145.java:80)
jib > at Test8173145.main(Test8173145.java:56)
jib > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
jib > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
jib > at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
jib > at
java.base/java.lang.reflect.Method.invoke(Method.java:566)
jib > at
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
jib > at java.base/java.lang.Thread.run(Thread.java:835)
So, I guess this is a valid fix.
http://cr.openjdk.java.net/~psadhukhan/8198334/webrev.0/test/jdk/com/sun/java/swing/plaf/windows/Test8173145.java.sdiff.html
Proposed webrev for newly created bug
Bug : https://bugs.openjdk.java.net/browse/JDK-8213514
webrev: http://cr.openjdk.java.net/~psadhukhan/8213514/webrev/
Regards
Prasanta
On 08-Nov-18 12:22 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
In the log of Test8173145 the ClassCastException exists as well:
https://bugs.openjdk.java.net/browse/JDK-8198334?focusedCommentId=14157839&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14157839
On 07/11/2018 01:29, Prasanta Sadhukhan wrote:
Hi Sergey,
Actually, I was more concerned about the swing test failure
com/sun/java/swing/plaf/windows/Test8173145 which I guess is
failing with HeadlessException. I can create a separate bug for
this test alone and handle this tag addition in the test case
w.r.t that bug.
Will that be fine?
For the 1st 2 awt tests, it seems to throw ClassCastEzxception
which I will leave alone. I was handling it only because it was
mixed with this swing test.
Regards
Prasanta
----- Original Message -----
From: sergey.bylok...@oracle.com
To: prasanta.sadhuk...@oracle.com, swing-dev@openjdk.java.net,
awt-...@openjdk.java.net
Sent: Wednesday, November 7, 2018 3:08:00 AM GMT +05:30 Chennai,
Kolkata, Mumbai, New Delhi
Subject: Re: <Swing Dev> [12] RFR JDK-8198334:
java/awt/FileDialog/8003399/bug8003399.java fails in headless mode
Hi, Prasanta.
An exception which was occurred in these tests are not
HeadlessException but ClassCastException
which is think is a product bug.
On 05/11/2018 02:16, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where some tests are found to
be failing with HeadlessException in mach5 systems.
Proposed fix is to mark those tests as headful.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198334
webrev: http://cr.openjdk.java.net/~psadhukhan/8198334/webrev.0/
Regards
Prasanta