Hi All, Please find the updated Webrev for this problem: http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.01/
Per the comments @ http://hg.openjdk.java.net/jdk/client/file/b5c564a1367c/src/java.desktop/share/classes/javax/accessibility/AccessibleState.java#l49, we need to update the missing entry for key 'managesDescendants' in AccessibleResourceBundle class. Any AccessibleState changes needs to be added an entry in AccessibleResourceBundle. The same has been added under this fix. After this fix, I am unable to reproduce it on my local machine. Thanks and regards, Shashi -----Original Message----- From: Shashidhara Veerabhadraiah Sent: Thursday, December 20, 2018 9:49 AM To: Sergey Bylokhov <sergey.bylok...@oracle.com>; swing-dev@openjdk.java.net; Philip Race <philip.r...@oracle.com>; Dmitry Bessonov <dmitry.besso...@oracle.com> Subject: Re: <Swing Dev> [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent Hi Sergey and Krishna, I was able to reproduce the problem on my machine yesterday evening. I will get back with another Webrev for this problem. So please wait for a day on this. Thanks and regards, Shashi -----Original Message----- From: Sergey Bylokhov Sent: Thursday, December 20, 2018 2:58 AM To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>; swing-dev@openjdk.java.net; Philip Race <philip.r...@oracle.com>; Dmitry Bessonov <dmitry.besso...@oracle.com> Subject: Re: [12] JDK-8213516: jck test api/javax_accessibility/AccessibleState/fields.html fails intermittent Hi, Shashi. Can you please describe the sequence of calls which might break the the static table? BTW did you tried the system where Dmitry was able to reproduce the bug? On 18/12/2018 22:24, Shashidhara Veerabhadraiah wrote: > Hi All, Please review a fix for the JDK 12 for the below bug: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8213516 > > Webrev: http://cr.openjdk.java.net/~sveerabhadra/8213516/webrev.00/ > > This issue is happening intermittently and am not able to reproduce it > on my local machine(corner case). As the bug reports issue is happening with > jtreg running multiple tests on same VM mode. Upon analysis of the > "AccessibleState" class and it's parent "AccessibleBundle" I think there may > be a chance that class variable(static variable: table) present in > AccessibleBundle can get into a corrupted state when multiple AccessibleState > class variables are calling the method of parent class (loadResourceBundle() > thro' toDisplayString() public functions) as it tries to load the same > resource file into the same table(static variable) possibly from different > threads(because of jtreg execution of multiple tests of the same bundle). > Hence added a synchronized keyword to the function so that execution goes > sequentially while loading the table(static hashtable). Since the problem is > intermittent and not reproducible on local machine, test file is not required > I think. Please suggest if you can find a different solution for this problem. -- Best regards, Sergey.
