Another point is that the whitespace trimming should not trigger
additional input processing for the custom class that will be used for
assistive technology. For eg., if custom class "FooProvider" is
implemented and if we pass " FooProvider " by mistake, a bug may be
created to trim the whitespace in this case as well!! Hence, I chose to
create only one path for not loading any assistive technologies. Hope
this answers, Sergey. Please let me know if you think otherwise.
Thanks and regards,
Shashi
On 17/01/19 10:28 AM, Shashidhara Veerabhadraiah wrote:
We need one way to tell the system not to load any assistive technologies and
which is being provided.
If we add trailing white spaces removal then we may need to add another
functionality to see if that class exists or not and based on that not to load
anything(without throwing the error because we are parsing the input content).
I think that would take a different direction. I feel it is fair enough to
provide one way to tell not to load any assistive technologies and additional
parsing would only lead to other ways/expectations.
Thanks and regards,
Shashi
-----Original Message-----
From: Sergey Bylokhov
Sent: Thursday, January 17, 2019 1:33 AM
To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>;
awt-...@openjdk.java.net; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [13] JDK-8216008:
-Djavax.accessibility.assistive_technologies empty list leads to crash
I guess you meant whitespaces, then it is unclear why we should not consider "empty"
parameter as a "mistake"?
On 15/01/2019 20:37, Shashidhara Veerabhadraiah wrote:
Hi Sergey, I felt that a string with an empty space is intentional and should
be considering it as a 'mistake' if done by the developers. Hence I feel it is
not required(as there is a way to tell nothing to load). Please let me know if
you think otherwise.
Thanks and regards,
Shashi
-----Original Message-----
From: Sergey Bylokhov
Sent: Tuesday, January 15, 2019 7:32 AM
To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>;
awt-...@openjdk.java.net; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [13] JDK-8216008:
-Djavax.accessibility.assistive_technologies empty list leads to crash
Hi, Shashi.
Should we trim all whitespaces from the "atNames"?
Otherwise the "atNames", which contains only one whitespace, will trigger the
same error.
On 09/01/2019 00:20, Shashidhara Veerabhadraiah wrote:
Hi Sergey, Thanks for pointing that out. Here is the new Webrev:
http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.01/
Thanks and regards,
Shashi
-----Original Message-----
From: Sergey Bylokhov
Sent: Friday, January 4, 2019 3:48 AM
To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>;
awt-...@openjdk.java.net; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [13] JDK-8216008:
-Djavax.accessibility.assistive_technologies empty list leads to crash
Hi, Shashi.
I think you can update an existing test:
open/test/jdk/javax/accessibility/AccessibilityProvider/basic.sh
On 03/01/2019 01:36, Shashidhara Veerabhadraiah wrote:
Hi All, Please review a fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8216008
Webrev: http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.00/
Since the mentioned list of assistive technologies for the system
property(javax.accessibility.assistive_technologies) is loaded by jvm am unable
to write a test case for this bug. The test file attached with the bug can be
used for testing this fix.
This fix removes the error(class not found error) by passing an empty list to
system variable javax.accessibility.assistive_technologies and does not load
any assistive technologies(as the list is empty). Currently empty list produce
a crash which is not required as there was no class name mentioned in the list.
Please read the bug comments for more information.
Thanks and regards,
Shashi
